jungm commented on PR #2849: URL: https://github.com/apache/tomee/pull/2849#issuecomment-5114378491
Ran the full build locally with the exact CI command on JDK 17 (matching `main-pull-request-build.yml`): ``` mvn help:system -U -ntp --batch-mode --show-version --fail-at-end clean install -DfailIfNoTests=false -DskipTests -Pstyle,rat ``` **BUILD SUCCESS** — all 326 modules, exit 0, no checkstyle or RAT violations. No code changes were needed, so there's nothing new to push; the GitHub `build` check on `d218410fd7` is also green. Two things worth flagging from doing this: 1. **Both CI workflows run `-DskipTests`** (155 "Tests are skipped" lines in my run), so the green check is compile + checkstyle + RAT only — the regression test added here has never actually executed in CI. I ran the affected suites separately on JDK 17: `tomee-catalina` 8/8 and `tomee-embedded` 21/21, including `UserTransactionLeakTest`. 2. My first attempt at this ran on JDK 25 and failed in `arquillian-openejb-transaction-provider`, `openejb-provisionning`, `openejb-mockito` and `openejb-multicast`. That was a toolchain mismatch, not a regression — none of those modules reference the classes touched here, and everything passes on the JDK 17 that CI uses. Mentioning it only so the failure isn't mistaken for something real if anyone builds on a newer JDK. The TCK precondition from your earlier review still stands: I have not run the Jakarta Transactions TCK, and the `apache/tomee-tck` exclusions are untouched. _🤖 Addressed by [Claude Code](https://claude.com/claude-code)_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
