jungm commented on PR #2945: URL: https://github.com/apache/tomee/pull/2945#issuecomment-5783714388
Pushed follow-ups for the review above: - The HTTP-dependent tests keep their coverage: they moved to `arquillian-tomee-jaxrs-tests` / `arquillian-tomee-jaxws-tests` and run on tomee-embedded (73 JAX-RS, 13 JAX-WS test classes). 20 examples run on Arquillian tomee-embedded; `rest-applicationcomposer`, `rest-applicationcomposer-mockito` and `applicationcomposer-jaxws-cdi` are removed. - The rest of the unreachable transport is gone (`HttpListenerRegistry`, `HttpRequestImpl`/`HttpResponseImpl`, `SessionManager`, `HttpUtil` servlet/filter registration and `reformat`, ...). - `RESTService`/`WsService` log a warning instead of an NPE when no registry exists. Stale `httpejbd` references, docs and the openejb-standalone deps are cleaned up; cdi-embedded excludes the CDI TCK tests that need HTTP. The ported tests surfaced pre-existing bugs: - Fixed in f8934e281d: `PortAddressRegistryImpl.removePort` never removed a port (inverted null check). - `@Ignore`d: EJB endpoints configured through `<ejb-deployment>` `cxf.jaxrs.*` properties answer 404 (`CheckedExceptionMapperTest`, `CxfRsHttpListener#isCXFResource`). - `@Ignore`d: a POJO web service servlet without a mapping never gets its default address mapped in Tomcat (`WsJMXTest`, `TomcatWsRegistry#setWsContainer`). Side note: CI doesn't run the CDI TCK (`-Ptck-cdi` isn't in master-build-full-tck), and it's currently broken (missing `xalan:serializer`, CDI TCK API mismatch). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
