jungm commented on PR #2945:
URL: https://github.com/apache/tomee/pull/2945#issuecomment-5853818114
Review pass pushed as 7 commits (b962f93d09..d8ed75bc22):
- `@RandomPort("http")` is an ordinary name; the message of e5b087a230 still
says it fails.
- Code only the embedded transport used is gone: `Proxys`,
`AppFinder.AppOrWebContextTransformer`, `LogCategory.HTTPSERVER`,
`LightServletContext`/`EmbeddedServletContextCreated`, the parser-only
`HttpRequest`/`HttpResponse` members, `CxfRsHttpListener`'s static resource
handling, the cxf-rs `auth`/`realm` settings, `@JaxrsProviders.applicationName`
and the regex REST wildcard. A missing Rs/WsRegistry logs at INFO, the
webprofile warned on every boot.
- Tests: `WsJMXTest` runs again, new `ServerDestroyedTest`,
`SuspendedTest`/`CdiHandlersTest` wait with a bound instead of racing the
server, `RsInterceptorInjectionTest` checks `isUserInRole` again,
httpejbd/EJBContainer leftovers removed.
- cdi-embedded TCK: `TckTlds` and `tomee-catalina` removed, the builtin
servlet decorator tests excluded, excludes already covered by `javaee-full`
dropped.
- Docs, examples (unused `ziplock`), openejb-standalone NOTICE/LICENSE (CXF,
XmlSchema, libre-wsdl4j) and the dependabot Jetty rule.
Found with 9 rounds of multi-agent review (runtime, tests, examples/docs and
build lanes, every finding challenged by a skeptic) until no finding survived.
Verified against branch-built jars: arquillian JAX-RS tests 169 run / 10
skipped, JAX-WS 33 run / 2 skipped, migrated examples pass. cdi-embedded is
only compile-checked, its harness is broken on main too.
Out of scope: `CheckedExceptionMapperTest` stays `@Ignore`d, deployment by
endpoint 404s on TomEE on main as well.
Ready for review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
