[tryton-commits] changeset in sao:default Do not recycle first record as product ...

[Cédric Krier]

changeset 9a6f271ea0a2 in sao:default
details: https://hg.tryton.org/sao?cmd=changeset;node=9a6f271ea0a2
description:
        Do not recycle first record as product result

        It is not affected by issue7941 but we follow anyway the same algorithm 
for
        both clients.

        review58461002
diffstat:

 src/view/form.js |  14 +++-----------
 1 files changed, 3 insertions(+), 11 deletions(-)

diffs (38 lines):

diff -r 75d1dfa162ec -r 9a6f271ea0a2 src/view/form.js
--- a/src/view/form.js  Mon Dec 31 15:36:49 2018 +0100
+++ b/src/view/form.js  Wed Jan 02 18:53:45 2019 +0100
@@ -3143,8 +3143,8 @@
                     }.bind(this);
 
                     var make_product = function() {
+                        screen.group.remove(first, true);
                         if (jQuery.isEmptyObject(product)) {
-                            screen.group.remove(first, true);
                             return;
                         }
 
@@ -3153,22 +3153,14 @@
                             return product[field];
                         });
                         Sao.common.product(values).forEach(function(values) {
-                            var set_default = function(record) {
+                            screen.new_(false).then(function(record) {
                                 var default_value = jQuery.extend({}, 
default_);
                                 fields.forEach(function(field, i) {
                                     default_value[field] = values[i][0];
                                     default_value[field + '.rec_name'] = 
values[i][1];
                                 });
                                 record.set_default(default_value);
-                            };
-
-                            var record;
-                            if (first) {
-                                set_default(first);
-                                first = null;
-                            } else {
-                                screen.new_(false).then(set_default);
-                            }
+                            });
                         });
                     };