changeset 467f0f8755f0 in modules/timesheet:default
details: https://hg.tryton.org/modules/timesheet?cmd=changeset;node=467f0f8755f0
description:
        Test if origin is ModelStorage instance before calling rec_name

        The origin could have a negative id and so the value is a string which 
is not
        usable origin for record name.

        issue7948
        review52581002
diffstat:

 work.py |  5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diffs (22 lines):

diff -r 6f2fad5966b6 -r 467f0f8755f0 work.py
--- a/work.py   Tue Jan 08 16:46:14 2019 +0100
+++ b/work.py   Tue Jan 15 00:03:52 2019 +0100
@@ -7,7 +7,8 @@
 from sql.aggregate import Sum
 
 from trytond.i18n import gettext
-from trytond.model import ModelView, ModelSQL, DeactivableMixin, fields, Unique
+from trytond.model import (
+    ModelView, ModelSQL, ModelStorage, DeactivableMixin, fields, Unique)
 from trytond.pyson import Not, Bool, Eval, If
 from trytond.transaction import Transaction
 from trytond.pool import Pool
@@ -172,7 +173,7 @@
         return self.id
 
     def get_rec_name(self, name):
-        if self.origin:
+        if isinstance(self.origin, ModelStorage):
             return self.origin.rec_name
         else:
             return self.name

Reply via email to