Subject: changeset in tryton:4.8 Connect dict widgets to the right activate callback From: Cédric Krier <[email protected]>
changeset f63e214bdd80 in tryton:4.8 details: https://hg.tryton.org/tryton?cmd=changeset;node=f63e214bdd80 description: Connect dict widgets to the right activate callback On activate of Entry and on toggle CheckButton, the parent must be activate. The toggled handler must also be blocked when activate the CheckButton by code to avoid unnecessary callbacks. issue7987 review49701002 (grafted from ef414bb17b26efcb835be1b6fb766f9193768b44) diffstat: tryton/gui/window/view_form/view/form_gtk/checkbox.py | 6 +++++- tryton/gui/window/view_form/view/form_gtk/dictionary.py | 11 +++++++++-- 2 files changed, 14 insertions(+), 3 deletions(-) diffs (48 lines): diff -r 49854ccda0db -r f63e214bdd80 tryton/gui/window/view_form/view/form_gtk/checkbox.py --- a/tryton/gui/window/view_form/view/form_gtk/checkbox.py Tue Jan 22 22:18:36 2019 +0100 +++ b/tryton/gui/window/view_form/view/form_gtk/checkbox.py Wed Jan 30 09:33:51 2019 +0100 @@ -28,4 +28,8 @@ if not field: self.widget.set_active(False) return False - self.widget.set_active(bool(field.get(record))) + self.widget.handler_block_by_func(self.sig_activate) + try: + self.widget.set_active(bool(field.get(record))) + finally: + self.widget.handler_unblock_by_func(self.sig_activate) diff -r 49854ccda0db -r f63e214bdd80 tryton/gui/window/view_form/view/form_gtk/dictionary.py --- a/tryton/gui/window/view_form/view/form_gtk/dictionary.py Tue Jan 22 22:18:36 2019 +0100 +++ b/tryton/gui/window/view_form/view/form_gtk/dictionary.py Wed Jan 30 09:33:51 2019 +0100 @@ -40,6 +40,8 @@ widget.connect('key-press-event', self.parent_widget.send_modified) widget.connect('focus-out-event', lambda w, e: self.parent_widget._focus_out()) + widget.props.activates_default = True + widget.connect('activate', self.parent_widget.sig_activate) return widget def modified(self, value): @@ -60,7 +62,7 @@ def create_widget(self): widget = gtk.CheckButton() - widget.connect('toggled', self.parent_widget.send_modified) + widget.connect('toggled', self.parent_widget.sig_activate) widget.connect('focus-out-event', lambda w, e: self.parent_widget._focus_out()) return widget @@ -69,7 +71,12 @@ return self.widget.props.active def set_value(self, value): - self.widget.props.active = bool(value) + self.widget.handler_block_by_func(self.parent_widget.sig_activate) + try: + self.widget.props.active = bool(value) + finally: + self.widget.handler_unblock_by_func( + self.parent_widget.sig_activate) def set_readonly(self, readonly): self.widget.set_sensitive(not readonly)
