Subject: changeset in tryton:5.0 Remove call to window_list_toplevels when destroying NoModal From: Cédric Krier <[email protected]>
changeset 44e71b721f86 in tryton:5.0 details: https://hg.tryton.org/tryton?cmd=changeset;node=44e71b721f86 description: Remove call to window_list_toplevels when destroying NoModal The test was added by changeset 5b5d0c1660e9 to prevent case when the parent was destoyed before the NoModal. This happened when creating a record from the search window. But this is no more the case with changeset b87844203f77 as the search window is destroyed before the creation of the form window. As the window_list_toplevels has shown multiple times to generate segmentation fault, it is safer to stop calling it and remove the test which is normally no more needed. issue8049 review52621002 (grafted from 57b75ada1af4b716ab162cdbfd8a896e886c936f) diffstat: tryton/gui/window/nomodal.py | 5 ----- 1 files changed, 0 insertions(+), 5 deletions(-) diffs (21 lines): diff -r c147d3e3920b -r 44e71b721f86 tryton/gui/window/nomodal.py --- a/tryton/gui/window/nomodal.py Sun Feb 03 20:19:17 2019 +0100 +++ b/tryton/gui/window/nomodal.py Sun Feb 03 20:25:03 2019 +0100 @@ -1,7 +1,5 @@ # This file is part of Tryton. The COPYRIGHT file at the top level of # this repository contains the full copyright notices and license terms. -import gtk - import tryton.common as common @@ -30,9 +28,6 @@ if not self.page: return self.page.dialogs.remove(self) - # Test if the parent is not already destroyed - if self.parent not in gtk.window_list_toplevels(): - return self.parent.present() self.sensible_widget.props.sensitive = True for focus in self.parent_focus:
