changeset 841e8f907d37 in tryton:default
details: https://hg.tryton.org/tryton?cmd=changeset;node=841e8f907d37
description:
        Open CSV file with empty newline

        The csv module takes care of managing the newline so we must open the 
file
        without the universal new line management.

        issue8006
        review269131002
diffstat:

 tryton/gui/window/win_export.py |  2 +-
 tryton/gui/window/win_import.py |  2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diffs (24 lines):

diff -r 033c66fe346b -r 841e8f907d37 tryton/gui/window/win_export.py
--- a/tryton/gui/window/win_export.py   Fri Mar 15 12:58:58 2019 +0100
+++ b/tryton/gui/window/win_export.py   Fri Mar 22 11:20:53 2019 +0100
@@ -300,7 +300,7 @@
 
         try:
             writer = csv.writer(
-                open(fname, 'w+', encoding=encoding),
+                open(fname, 'w', encoding=encoding, newline=''),
                 quotechar=self.get_quotechar(),
                 delimiter=self.get_delimiter())
             if self.add_field_names.get_active():
diff -r 033c66fe346b -r 841e8f907d37 tryton/gui/window/win_import.py
--- a/tryton/gui/window/win_import.py   Fri Mar 15 12:58:58 2019 +0100
+++ b/tryton/gui/window/win_import.py   Fri Mar 22 11:20:53 2019 +0100
@@ -109,7 +109,7 @@
         self.csv_skip.set_value(1)
         try:
             data = csv.reader(
-                open(fname, 'r', encoding=encoding),
+                open(fname, 'r', encoding=encoding, newline=''),
                 quotechar=self.get_quotechar(),
                 delimiter=self.get_delimiter())
         except IOError:

Reply via email to