changeset 56e838a7ef9d in sao:4.8
details: https://hg.tryton.org/sao?cmd=changeset;node=56e838a7ef9d
description:
        Test if attribute readonly is undefined before using states value

        This is the general behavior for readonly attribute so
        RowEditable.set_editable must follow it to avoid incoherent behavior.

        issue8390
        review249401002
        (grafted from 7c9da8ff4d4fb7de56f005d2f276ad5ad56c8d41)
diffstat:

 src/view/tree.js |  8 +++++++-
 1 files changed, 7 insertions(+), 1 deletions(-)

diffs (18 lines):

diff -r faf28980662f -r 56e838a7ef9d src/view/tree.js
--- a/src/view/tree.js  Mon Jun 10 18:34:59 2019 +0200
+++ b/src/view/tree.js  Wed Jun 12 19:06:19 2019 +0200
@@ -1319,7 +1319,13 @@
                     continue;
                 }
                 var state_attrs = col.field.get_state_attrs(this.record);
-                var readonly = col.attributes.readonly || state_attrs.readonly;
+                var readonly = col.attributes.readonly;
+                if (readonly === undefined) {
+                    readonly = state_attrs.readonly;
+                    if (readonly === undefined) {
+                        readonly = false;
+                    }
+                }
 
                 if (!readonly) {
                     var EditableBuilder = Sao.View.editabletree_widget_get(

Reply via email to