changeset 03dd71d3c66a in www.tryton.org:default
details: https://hg.tryton.org/www.tryton.org?cmd=changeset;node=03dd71d3c66a
description:
Add running tests step to submit change
review264151002
diffstat:
templates/develop.html | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diffs (11 lines):
diff -r 2b60a7b75cf5 -r 03dd71d3c66a templates/develop.html
--- a/templates/develop.html Sun Aug 11 09:30:00 2019 +0200
+++ b/templates/develop.html Wed Sep 11 23:42:00 2019 +0200
@@ -65,6 +65,7 @@
<li>Submit your change to our <a
href="https://codereview.tryton.org/">review tool</a> using the <a
href="https://codereview.tryton.org/static/upload.py">upload.py</a> script (see
the <a href="https://github.com/rietveld-codereview/rietveld/wiki">help
page</a>).</li>
<li>Make sure the review has the repository name at the start of the
review title,
and ensure the review description contains a reference to the
issue (e.g.: <span class="text-monospace">issue1234</span>).</li>
+ <li>Ensure you did not break the tests by running them and add tests
if necessary.</li>
<li>Once accepted your review will be validated with a
<mark>LGTM</mark> comment from a core developer</li>
<li>Your change will then be committed and pushed by a core developer.
The commit message will be the review subject (with repository
name stripped) and the review description.