changeset ff5a76bbdbc8 in modules/account_invoice:default
details:
https://hg.tryton.org/modules/account_invoice?cmd=changeset;node=ff5a76bbdbc8
description:
Test both reverse operations to invalidate ratio and divisor
When the value has repeating decimal, the comparison may fail for one
comparison but we must consider as valid value.
issue8966
review265001002
diffstat:
payment_term.py | 9 ++++-----
1 files changed, 4 insertions(+), 5 deletions(-)
diffs (19 lines):
diff -r f2fffd6bd279 -r ff5a76bbdbc8 payment_term.py
--- a/payment_term.py Sat Dec 28 17:48:50 2019 +0100
+++ b/payment_term.py Mon Jan 20 11:06:23 2020 +0100
@@ -222,11 +222,10 @@
gettext('account_invoice'
'.msg_payment_term_invalid_ratio_divisor',
line=line.rec_name))
- ratio = line.ratio
- divisor = line.divisor
- line.on_change_ratio()
- line.on_change_divisor()
- if (line.divisor != divisor) or (line.ratio != ratio):
+ if (line.ratio != round(
+ 1 / line.divisor, cls.ratio.digits[1])
+ and line.divisor != round(
+ 1 / line.ratio, cls.divisor.digits[1])):
raise PaymentTermValidationError(
gettext('account_invoice'
'.msg_payment_term_invalid_ratio_divisor',
