changeset 5bbedf67c042 in modules/account_credit_limit:default
details:
https://hg.tryton.org/modules/account_credit_limit?cmd=changeset;node=5bbedf67c042
description:
Fix flake8 errors and warnings
We add the flake8 configuration used so we ensure everyone uses the
same.
We remove the usage of __all__ for non public API.
When possible, we rationalize the class name according to its __name__
and module.
issue9082
review297061002
diffstat:
.flake8 | 2 ++
account.py | 1 -
party.py | 2 --
setup.py | 7 ++++---
tests/__init__.py | 2 +-
5 files changed, 7 insertions(+), 7 deletions(-)
diffs (65 lines):
diff -r 7c25af4058ef -r 5bbedf67c042 .flake8
--- /dev/null Thu Jan 01 00:00:00 1970 +0000
+++ b/.flake8 Sun Mar 01 12:33:51 2020 +0100
@@ -0,0 +1,2 @@
+[flake8]
+ignore=E123,E124,E126,E128,W503
diff -r 7c25af4058ef -r 5bbedf67c042 account.py
--- a/account.py Fri Dec 06 17:33:46 2019 +0100
+++ b/account.py Sun Mar 01 12:33:51 2020 +0100
@@ -6,7 +6,6 @@
from trytond.pyson import Eval
from trytond.modules.company.model import CompanyValueMixin
-__all__ = ['Configuration', 'ConfigurationDefaultCreditLimitAmount', 'Level']
default_credit_limit_amount = fields.Numeric(
"Default Credit Limit Amount",
help="The default credit limit amount for new customers.",
diff -r 7c25af4058ef -r 5bbedf67c042 party.py
--- a/party.py Fri Dec 06 17:33:46 2019 +0100
+++ b/party.py Sun Mar 01 12:33:51 2020 +0100
@@ -11,8 +11,6 @@
from .exceptions import CreditLimitError, CreditLimitWarning
-__all__ = ['Party', 'PartyCreditLimitAmount']
-
class Party(metaclass=PoolMeta):
__name__ = 'party.party'
diff -r 7c25af4058ef -r 5bbedf67c042 setup.py
--- a/setup.py Fri Dec 06 17:33:46 2019 +0100
+++ b/setup.py Sun Mar 01 12:33:51 2020 +0100
@@ -79,8 +79,8 @@
keywords='tryton account credit limit',
package_dir={'trytond.modules.account_credit_limit': '.'},
packages=(
- ['trytond.modules.account_credit_limit'] +
- ['trytond.modules.account_credit_limit.%s' % p
+ ['trytond.modules.account_credit_limit']
+ + ['trytond.modules.account_credit_limit.%s' % p
for p in find_packages()]
),
package_data={
@@ -94,7 +94,8 @@
'Intended Audience :: Developers',
'Intended Audience :: Financial and Insurance Industry',
'Intended Audience :: Legal Industry',
- 'License :: OSI Approved :: GNU General Public License v3 or later
(GPLv3+)',
+ 'License :: OSI Approved :: '
+ 'GNU General Public License v3 or later (GPLv3+)',
'Natural Language :: Bulgarian',
'Natural Language :: Catalan',
'Natural Language :: Chinese (Simplified)',
diff -r 7c25af4058ef -r 5bbedf67c042 tests/__init__.py
--- a/tests/__init__.py Fri Dec 06 17:33:46 2019 +0100
+++ b/tests/__init__.py Sun Mar 01 12:33:51 2020 +0100
@@ -2,7 +2,7 @@
# this repository contains the full copyright notices and license terms.
try:
- from trytond.modules.account_credit_limit.tests.test_account_credit_limit
import suite
+ from trytond.modules.account_credit_limit.tests.test_account_credit_limit
import suite # noqa: E501
except ImportError:
from .test_account_credit_limit import suite
