changeset 9d2ba0084e66 in modules/account_dunning_letter:default
details:
https://hg.tryton.org/modules/account_dunning_letter?cmd=changeset;node=9d2ba0084e66
description:
Fix flake8 errors and warnings
We add the flake8 configuration used so we ensure everyone uses the
same.
We remove the usage of __all__ for non public API.
When possible, we rationalize the class name according to its __name__
and module.
issue9082
review297061002
diffstat:
.flake8 | 2 ++
__init__.py | 8 ++++----
dunning.py | 3 ---
setup.py | 7 ++++---
tests/__init__.py | 2 +-
5 files changed, 11 insertions(+), 11 deletions(-)
diffs (79 lines):
diff -r 8f6c15ebc0f9 -r 9d2ba0084e66 .flake8
--- /dev/null Thu Jan 01 00:00:00 1970 +0000
+++ b/.flake8 Sun Mar 01 12:33:51 2020 +0100
@@ -0,0 +1,2 @@
+[flake8]
+ignore=E123,E124,E126,E128,W503
diff -r 8f6c15ebc0f9 -r 9d2ba0084e66 __init__.py
--- a/__init__.py Wed Dec 04 11:09:35 2019 +0100
+++ b/__init__.py Sun Mar 01 12:33:51 2020 +0100
@@ -2,16 +2,16 @@
# this repository contains the full copyright notices and license terms.
from trytond.pool import Pool
-from .dunning import *
+from . import dunning
def register():
Pool.register(
- Level,
+ dunning.Level,
module='account_dunning_letter', type_='model')
Pool.register(
- ProcessDunning,
+ dunning.ProcessDunning,
module='account_dunning_letter', type_='wizard')
Pool.register(
- Letter,
+ dunning.Letter,
module='account_dunning_letter', type_='report')
diff -r 8f6c15ebc0f9 -r 9d2ba0084e66 dunning.py
--- a/dunning.py Wed Dec 04 11:09:35 2019 +0100
+++ b/dunning.py Sun Mar 01 12:33:51 2020 +0100
@@ -12,9 +12,6 @@
from trytond.tools import grouped_slice
-__all__ = ['Level', 'ProcessDunning', 'Letter']
-
-
class Level(metaclass=PoolMeta):
__name__ = 'account.dunning.level'
print_on_letter = fields.Boolean('Print on Letter')
diff -r 8f6c15ebc0f9 -r 9d2ba0084e66 setup.py
--- a/setup.py Wed Dec 04 11:09:35 2019 +0100
+++ b/setup.py Sun Mar 01 12:33:51 2020 +0100
@@ -79,8 +79,8 @@
keywords='tryton account dunning letter',
package_dir={'trytond.modules.account_dunning_letter': '.'},
packages=(
- ['trytond.modules.account_dunning_letter'] +
- ['trytond.modules.account_dunning_letter.%s' % p
+ ['trytond.modules.account_dunning_letter']
+ + ['trytond.modules.account_dunning_letter.%s' % p
for p in find_packages()]
),
package_data={
@@ -95,7 +95,8 @@
'Intended Audience :: Developers',
'Intended Audience :: Financial and Insurance Industry',
'Intended Audience :: Legal Industry',
- 'License :: OSI Approved :: GNU General Public License v3 or later
(GPLv3+)',
+ 'License :: OSI Approved :: '
+ 'GNU General Public License v3 or later (GPLv3+)',
'Natural Language :: Bulgarian',
'Natural Language :: Catalan',
'Natural Language :: Chinese (Simplified)',
diff -r 8f6c15ebc0f9 -r 9d2ba0084e66 tests/__init__.py
--- a/tests/__init__.py Wed Dec 04 11:09:35 2019 +0100
+++ b/tests/__init__.py Sun Mar 01 12:33:51 2020 +0100
@@ -2,7 +2,7 @@
# this repository contains the full copyright notices and license terms.
try:
- from
trytond.modules.account_dunning_letter.tests.test_account_dunning_letter import
suite
+ from
trytond.modules.account_dunning_letter.tests.test_account_dunning_letter import
suite # noqa: E501
except ImportError:
from .test_account_dunning_letter import suite
