changeset 332d5f4a87d8 in modules/account_dunning_fee:default
details:
https://hg.tryton.org/modules/account_dunning_fee?cmd=changeset;node=332d5f4a87d8
description:
Fix flake8 errors and warnings
We add the flake8 configuration used so we ensure everyone uses the
same.
We remove the usage of __all__ for non public API.
When possible, we rationalize the class name according to its __name__
and module.
issue9082
review297061002
diffstat:
.flake8 | 2 ++
account.py | 2 --
dunning.py | 2 --
setup.py | 8 +++++---
tests/__init__.py | 2 +-
5 files changed, 8 insertions(+), 8 deletions(-)
diffs (67 lines):
diff -r c23ad4bdc9d1 -r 332d5f4a87d8 .flake8
--- /dev/null Thu Jan 01 00:00:00 1970 +0000
+++ b/.flake8 Sun Mar 01 12:33:51 2020 +0100
@@ -0,0 +1,2 @@
+[flake8]
+ignore=E123,E124,E126,E128,W503
diff -r c23ad4bdc9d1 -r 332d5f4a87d8 account.py
--- a/account.py Wed Dec 04 11:09:35 2019 +0100
+++ b/account.py Sun Mar 01 12:33:51 2020 +0100
@@ -2,8 +2,6 @@
# this repository contains the full copyright notices and license terms.
from trytond.pool import PoolMeta
-__all__ = ['Move']
-
class Move(metaclass=PoolMeta):
__name__ = 'account.move'
diff -r c23ad4bdc9d1 -r 332d5f4a87d8 dunning.py
--- a/dunning.py Wed Dec 04 11:09:35 2019 +0100
+++ b/dunning.py Sun Mar 01 12:33:51 2020 +0100
@@ -7,8 +7,6 @@
from trytond.pyson import Eval
from trytond.transaction import Transaction
-__all__ = ['Fee', 'Level', 'Dunning', 'FeeDunningLevel', 'Letter']
-
class Fee(DeactivableMixin, ModelSQL, ModelView):
'Account Dunning Fee'
diff -r c23ad4bdc9d1 -r 332d5f4a87d8 setup.py
--- a/setup.py Wed Dec 04 11:09:35 2019 +0100
+++ b/setup.py Sun Mar 01 12:33:51 2020 +0100
@@ -80,8 +80,9 @@
keywords='account dunning fee',
package_dir={'trytond.modules.account_dunning_fee': '.'},
packages=(
- ['trytond.modules.account_dunning_fee'] +
- ['trytond.modules.account_dunning_fee.%s' % p for p in find_packages()]
+ ['trytond.modules.account_dunning_fee']
+ + ['trytond.modules.account_dunning_fee.%s' % p
+ for p in find_packages()]
),
package_data={
'trytond.modules.account_dunning_fee': (info.get('xml', [])
@@ -95,7 +96,8 @@
'Intended Audience :: Developers',
'Intended Audience :: Financial and Insurance Industry',
'Intended Audience :: Legal Industry',
- 'License :: OSI Approved :: GNU General Public License v3 or later
(GPLv3+)',
+ 'License :: OSI Approved :: '
+ 'GNU General Public License v3 or later (GPLv3+)',
'Natural Language :: Bulgarian',
'Natural Language :: Catalan',
'Natural Language :: Czech',
diff -r c23ad4bdc9d1 -r 332d5f4a87d8 tests/__init__.py
--- a/tests/__init__.py Wed Dec 04 11:09:35 2019 +0100
+++ b/tests/__init__.py Sun Mar 01 12:33:51 2020 +0100
@@ -2,7 +2,7 @@
# this repository contains the full copyright notices and license terms.
try:
- from trytond.modules.account_dunning_fee.tests.test_account_dunning_fee
import suite
+ from trytond.modules.account_dunning_fee.tests.test_account_dunning_fee
import suite # noqa: E501
except ImportError:
from .test_account_dunning_fee import suite
