changeset 477c6148aa7b in modules/account_invoice_history:default
details:
https://hg.tryton.org/modules/account_invoice_history?cmd=changeset;node=477c6148aa7b
description:
Fix flake8 errors and warnings
We add the flake8 configuration used so we ensure everyone uses the
same.
We remove the usage of __all__ for non public API.
When possible, we rationalize the class name according to its __name__
and module.
issue9082
review297061002
diffstat:
.flake8 | 2 ++
account.py | 2 --
party.py | 2 --
setup.py | 7 ++++---
tests/__init__.py | 2 +-
5 files changed, 7 insertions(+), 8 deletions(-)
diffs (66 lines):
diff -r 0f55e8010557 -r 477c6148aa7b .flake8
--- /dev/null Thu Jan 01 00:00:00 1970 +0000
+++ b/.flake8 Sun Mar 01 12:33:51 2020 +0100
@@ -0,0 +1,2 @@
+[flake8]
+ignore=E123,E124,E126,E128,W503
diff -r 0f55e8010557 -r 477c6148aa7b account.py
--- a/account.py Wed Dec 18 21:35:22 2019 +0100
+++ b/account.py Sun Mar 01 12:33:51 2020 +0100
@@ -6,8 +6,6 @@
from trytond.pool import PoolMeta
from trytond.transaction import Transaction
-__all__ = ['Invoice']
-
class Invoice(metaclass=PoolMeta):
__name__ = 'account.invoice'
diff -r 0f55e8010557 -r 477c6148aa7b party.py
--- a/party.py Wed Dec 18 21:35:22 2019 +0100
+++ b/party.py Sun Mar 01 12:33:51 2020 +0100
@@ -2,8 +2,6 @@
# this repository contains the full copyright notices and license terms.
from trytond.pool import PoolMeta
-__all__ = ['Party', 'Address']
-
class Party(metaclass=PoolMeta):
__name__ = 'party.party'
diff -r 0f55e8010557 -r 477c6148aa7b setup.py
--- a/setup.py Wed Dec 18 21:35:22 2019 +0100
+++ b/setup.py Sun Mar 01 12:33:51 2020 +0100
@@ -78,8 +78,8 @@
keywords='tryton account invoice history',
package_dir={'trytond.modules.account_invoice_history': '.'},
packages=(
- ['trytond.modules.account_invoice_history'] +
- ['trytond.modules.account_invoice_history.%s' % p
+ ['trytond.modules.account_invoice_history']
+ + ['trytond.modules.account_invoice_history.%s' % p
for p in find_packages()]
),
package_data={
@@ -93,7 +93,8 @@
'Intended Audience :: Developers',
'Intended Audience :: Financial and Insurance Industry',
'Intended Audience :: Legal Industry',
- 'License :: OSI Approved :: GNU General Public License v3 or later
(GPLv3+)',
+ 'License :: OSI Approved :: '
+ 'GNU General Public License v3 or later (GPLv3+)',
'Natural Language :: Bulgarian',
'Natural Language :: Catalan',
'Natural Language :: Chinese (Simplified)',
diff -r 0f55e8010557 -r 477c6148aa7b tests/__init__.py
--- a/tests/__init__.py Wed Dec 18 21:35:22 2019 +0100
+++ b/tests/__init__.py Sun Mar 01 12:33:51 2020 +0100
@@ -2,7 +2,7 @@
# this repository contains the full copyright notices and license terms.
try:
- from
trytond.modules.account_invoice_history.tests.test_account_invoice_history
import suite
+ from
trytond.modules.account_invoice_history.tests.test_account_invoice_history
import suite # noqa: E501
except ImportError:
from .test_account_invoice_history import suite
