changeset b4605535b1ac in modules/account_invoice_line_standalone:default
details:
https://hg.tryton.org/modules/account_invoice_line_standalone?cmd=changeset;node=b4605535b1ac
description:
Fix flake8 errors and warnings
We add the flake8 configuration used so we ensure everyone uses the
same.
We remove the usage of __all__ for non public API.
When possible, we rationalize the class name according to its __name__
and module.
issue9082
review297061002
diffstat:
.flake8 | 2 ++
__init__.py | 6 +++---
invoice.py | 2 --
setup.py | 7 ++++---
tests/__init__.py | 2 +-
5 files changed, 10 insertions(+), 9 deletions(-)
diffs (72 lines):
diff -r 06754e4fb1a5 -r b4605535b1ac .flake8
--- /dev/null Thu Jan 01 00:00:00 1970 +0000
+++ b/.flake8 Sun Mar 01 12:33:51 2020 +0100
@@ -0,0 +1,2 @@
+[flake8]
+ignore=E123,E124,E126,E128,W503
diff -r 06754e4fb1a5 -r b4605535b1ac __init__.py
--- a/__init__.py Wed Dec 04 11:09:35 2019 +0100
+++ b/__init__.py Sun Mar 01 12:33:51 2020 +0100
@@ -2,11 +2,11 @@
# this repository contains the full copyright notices and license terms.
from trytond.pool import Pool
-from .invoice import *
+from . import invoice
def register():
Pool.register(
- Invoice,
- InvoiceLine,
+ invoice.Invoice,
+ invoice.InvoiceLine,
module='account_invoice_line_standalone', type_='model')
diff -r 06754e4fb1a5 -r b4605535b1ac invoice.py
--- a/invoice.py Wed Dec 04 11:09:35 2019 +0100
+++ b/invoice.py Sun Mar 01 12:33:51 2020 +0100
@@ -4,8 +4,6 @@
from trytond.transaction import Transaction
from trytond.pool import PoolMeta
-__all__ = ['Invoice', 'InvoiceLine']
-
class Invoice(metaclass=PoolMeta):
__name__ = 'account.invoice'
diff -r 06754e4fb1a5 -r b4605535b1ac setup.py
--- a/setup.py Wed Dec 04 11:09:35 2019 +0100
+++ b/setup.py Sun Mar 01 12:33:51 2020 +0100
@@ -79,8 +79,8 @@
keywords='tryton account standalone invoice line',
package_dir={'trytond.modules.account_invoice_line_standalone': '.'},
packages=(
- ['trytond.modules.account_invoice_line_standalone'] +
- ['trytond.modules.account_invoice_line_standalone.%s' % p
+ ['trytond.modules.account_invoice_line_standalone']
+ + ['trytond.modules.account_invoice_line_standalone.%s' % p
for p in find_packages()]
),
package_data={
@@ -94,7 +94,8 @@
'Intended Audience :: Developers',
'Intended Audience :: Legal Industry',
'Intended Audience :: Manufacturing',
- 'License :: OSI Approved :: GNU General Public License v3 or later
(GPLv3+)',
+ 'License :: OSI Approved :: '
+ 'GNU General Public License v3 or later (GPLv3+)',
'Natural Language :: Bulgarian',
'Natural Language :: Catalan',
'Natural Language :: Chinese (Simplified)',
diff -r 06754e4fb1a5 -r b4605535b1ac tests/__init__.py
--- a/tests/__init__.py Wed Dec 04 11:09:35 2019 +0100
+++ b/tests/__init__.py Sun Mar 01 12:33:51 2020 +0100
@@ -2,7 +2,7 @@
# this repository contains the full copyright notices and license terms.
try:
- from
trytond.modules.account_invoice_line_standalone.tests.test_account_invoice_line_standalone
import suite
+ from
trytond.modules.account_invoice_line_standalone.tests.test_account_invoice_line_standalone
import suite # noqa: E501
except ImportError:
from .test_account_invoice_line_standalone import suite
