changeset f2adf6087084 in modules/account_stock_landed_cost:default
details:
https://hg.tryton.org/modules/account_stock_landed_cost?cmd=changeset;node=f2adf6087084
description:
Fix flake8 errors and warnings
We add the flake8 configuration used so we ensure everyone uses the
same.
We remove the usage of __all__ for non public API.
When possible, we rationalize the class name according to its __name__
and module.
issue9082
review297061002
diffstat:
.flake8 | 2 ++
__init__.py | 22 +++++++++++-----------
account.py | 3 ---
product.py | 3 ---
setup.py | 7 ++++---
stock.py | 3 ---
tests/__init__.py | 2 +-
7 files changed, 18 insertions(+), 24 deletions(-)
diffs (115 lines):
diff -r 34898d28cdcd -r f2adf6087084 .flake8
--- /dev/null Thu Jan 01 00:00:00 1970 +0000
+++ b/.flake8 Sun Mar 01 12:33:51 2020 +0100
@@ -0,0 +1,2 @@
+[flake8]
+ignore=E123,E124,E126,E128,W503
diff -r 34898d28cdcd -r f2adf6087084 __init__.py
--- a/__init__.py Fri Dec 06 17:33:46 2019 +0100
+++ b/__init__.py Sun Mar 01 12:33:51 2020 +0100
@@ -2,19 +2,19 @@
# this repository contains the full copyright notices and license terms.
from trytond.pool import Pool
-from .product import *
-from .account import *
-from .stock import *
+from . import product
+from . import account
+from . import stock
def register():
Pool.register(
- Template,
- Product,
- Configuration,
- ConfigurationLandedCostSequence,
- LandedCost,
- LandedCost_Shipment,
- InvoiceLine,
- Move,
+ product.Template,
+ product.Product,
+ account.Configuration,
+ account.ConfigurationLandedCostSequence,
+ account.LandedCost,
+ account.LandedCost_Shipment,
+ account.InvoiceLine,
+ stock.Move,
module='account_stock_landed_cost', type_='model')
diff -r 34898d28cdcd -r f2adf6087084 account.py
--- a/account.py Fri Dec 06 17:33:46 2019 +0100
+++ b/account.py Sun Mar 01 12:33:51 2020 +0100
@@ -11,9 +11,6 @@
from trytond.tools.multivalue import migrate_property
from trytond.modules.company.model import CompanyValueMixin
-__all__ = ['Configuration', 'ConfigurationLandedCostSequence',
- 'LandedCost', 'LandedCost_Shipment', 'InvoiceLine']
-
class Configuration(metaclass=PoolMeta):
__name__ = 'account.configuration'
diff -r 34898d28cdcd -r f2adf6087084 product.py
--- a/product.py Fri Dec 06 17:33:46 2019 +0100
+++ b/product.py Sun Mar 01 12:33:51 2020 +0100
@@ -5,9 +5,6 @@
from trytond.pyson import Eval
-__all__ = ['Template', 'Product']
-
-
class Template(metaclass=PoolMeta):
__name__ = 'product.template'
landed_cost = fields.Boolean('Landed Cost', states={
diff -r 34898d28cdcd -r f2adf6087084 setup.py
--- a/setup.py Fri Dec 06 17:33:46 2019 +0100
+++ b/setup.py Sun Mar 01 12:33:51 2020 +0100
@@ -80,8 +80,8 @@
keywords='tryton account stock valuation landed cost',
package_dir={'trytond.modules.account_stock_landed_cost': '.'},
packages=(
- ['trytond.modules.account_stock_landed_cost'] +
- ['trytond.modules.account_stock_landed_cost.%s' % p
+ ['trytond.modules.account_stock_landed_cost']
+ + ['trytond.modules.account_stock_landed_cost.%s' % p
for p in find_packages()]
),
package_data={
@@ -95,7 +95,8 @@
'Intended Audience :: Developers',
'Intended Audience :: Financial and Insurance Industry',
'Intended Audience :: Legal Industry',
- 'License :: OSI Approved :: GNU General Public License v3 or later
(GPLv3+)',
+ 'License :: OSI Approved :: '
+ 'GNU General Public License v3 or later (GPLv3+)',
'Natural Language :: Bulgarian',
'Natural Language :: Catalan',
'Natural Language :: Chinese (Simplified)',
diff -r 34898d28cdcd -r f2adf6087084 stock.py
--- a/stock.py Fri Dec 06 17:33:46 2019 +0100
+++ b/stock.py Sun Mar 01 12:33:51 2020 +0100
@@ -5,9 +5,6 @@
from trytond.modules.product import price_digits
-__all__ = ['Move']
-
-
class Move(metaclass=PoolMeta):
__name__ = 'stock.move'
unit_landed_cost = fields.Numeric('Unit Landed Cost',
diff -r 34898d28cdcd -r f2adf6087084 tests/__init__.py
--- a/tests/__init__.py Fri Dec 06 17:33:46 2019 +0100
+++ b/tests/__init__.py Sun Mar 01 12:33:51 2020 +0100
@@ -2,7 +2,7 @@
# this repository contains the full copyright notices and license terms.
try:
- from
trytond.modules.account_stock_landed_cost.tests.test_account_stock_landed_cost
import suite
+ from
trytond.modules.account_stock_landed_cost.tests.test_account_stock_landed_cost
import suite # noqa: E501
except ImportError:
from .test_account_stock_landed_cost import suite
