changeset 9a91688ee276 in modules/account_invoice_stock:default
details:
https://hg.tryton.org/modules/account_invoice_stock?cmd=changeset;node=9a91688ee276
description:
Fix flake8 errors and warnings
We add the flake8 configuration used so we ensure everyone uses the
same.
We remove the usage of __all__ for non public API.
When possible, we rationalize the class name according to its __name__
and module.
issue9082
review297061002
diffstat:
.flake8 | 2 ++
__init__.py | 10 +++++-----
account.py | 3 ---
setup.py | 7 ++++---
stock.py | 7 ++-----
tests/__init__.py | 2 +-
6 files changed, 14 insertions(+), 17 deletions(-)
diffs (98 lines):
diff -r 9d3b5cbebbe2 -r 9a91688ee276 .flake8
--- /dev/null Thu Jan 01 00:00:00 1970 +0000
+++ b/.flake8 Sun Mar 01 12:33:51 2020 +0100
@@ -0,0 +1,2 @@
+[flake8]
+ignore=E123,E124,E126,E128,W503
diff -r 9d3b5cbebbe2 -r 9a91688ee276 __init__.py
--- a/__init__.py Wed Dec 04 11:09:35 2019 +0100
+++ b/__init__.py Sun Mar 01 12:33:51 2020 +0100
@@ -2,13 +2,13 @@
# this repository contains the full copyright notices and license terms.
from trytond.pool import Pool
-from .account import *
-from .stock import *
+from . import account
+from . import stock
def register():
Pool.register(
- InvoiceLineStockMove,
- InvoiceLine,
- StockMove,
+ account.InvoiceLineStockMove,
+ account.InvoiceLine,
+ stock.Move,
module='account_invoice_stock', type_='model')
diff -r 9d3b5cbebbe2 -r 9a91688ee276 account.py
--- a/account.py Wed Dec 04 11:09:35 2019 +0100
+++ b/account.py Sun Mar 01 12:33:51 2020 +0100
@@ -5,9 +5,6 @@
from trytond.pyson import Eval
-__all__ = ['InvoiceLineStockMove', 'InvoiceLine']
-
-
class InvoiceLineStockMove(ModelSQL):
'Invoice Line - Stock Move'
__name__ = 'account.invoice.line-stock.move'
diff -r 9d3b5cbebbe2 -r 9a91688ee276 setup.py
--- a/setup.py Wed Dec 04 11:09:35 2019 +0100
+++ b/setup.py Sun Mar 01 12:33:51 2020 +0100
@@ -78,8 +78,8 @@
keywords='tryton account invoice stock',
package_dir={'trytond.modules.account_invoice_stock': '.'},
packages=(
- ['trytond.modules.account_invoice_stock'] +
- ['trytond.modules.account_invoice_stock.%s' % p
+ ['trytond.modules.account_invoice_stock']
+ + ['trytond.modules.account_invoice_stock.%s' % p
for p in find_packages()]
),
package_data={
@@ -93,7 +93,8 @@
'Intended Audience :: Developers',
'Intended Audience :: Financial and Insurance Industry',
'Intended Audience :: Legal Industry',
- 'License :: OSI Approved :: GNU General Public License v3 or later
(GPLv3+)',
+ 'License :: OSI Approved :: '
+ 'GNU General Public License v3 or later (GPLv3+)',
'Natural Language :: Bulgarian',
'Natural Language :: Catalan',
'Natural Language :: Chinese (Simplified)',
diff -r 9d3b5cbebbe2 -r 9a91688ee276 stock.py
--- a/stock.py Wed Dec 04 11:09:35 2019 +0100
+++ b/stock.py Sun Mar 01 12:33:51 2020 +0100
@@ -5,10 +5,7 @@
from trytond.transaction import Transaction
-__all__ = ['StockMove']
-
-
-class StockMove(metaclass=PoolMeta):
+class Move(metaclass=PoolMeta):
__name__ = 'stock.move'
invoice_lines = fields.Many2Many('account.invoice.line-stock.move',
'stock_move', 'invoice_line', 'Invoice Lines')
@@ -32,4 +29,4 @@
default = default.copy()
if not Transaction().context.get('_stock_move_split'):
default.setdefault('invoice_lines', None)
- return super(StockMove, cls).copy(moves, default=default)
+ return super().copy(moves, default=default)
diff -r 9d3b5cbebbe2 -r 9a91688ee276 tests/__init__.py
--- a/tests/__init__.py Wed Dec 04 11:09:35 2019 +0100
+++ b/tests/__init__.py Sun Mar 01 12:33:51 2020 +0100
@@ -2,7 +2,7 @@
# this repository contains the full copyright notices and license terms.
try:
- from
trytond.modules.account_invoice_stock.tests.test_account_invoice_stock import
suite
+ from
trytond.modules.account_invoice_stock.tests.test_account_invoice_stock import
suite # noqa: E501
except ImportError:
from .test_account_invoice_stock import suite
