changeset 78201a321578 in modules/account_payment_sepa_cfonb:default
details:
https://hg.tryton.org/modules/account_payment_sepa_cfonb?cmd=changeset;node=78201a321578
description:
Fix flake8 errors and warnings
We add the flake8 configuration used so we ensure everyone uses the
same.
We remove the usage of __all__ for non public API.
When possible, we rationalize the class name according to its __name__
and module.
issue9082
review297061002
diffstat:
.flake8 | 2 ++
__init__.py | 6 +++---
payment.py | 4 +---
setup.py | 7 ++++---
tests/__init__.py | 2 +-
5 files changed, 11 insertions(+), 10 deletions(-)
diffs (81 lines):
diff -r aa6c2b86af44 -r 78201a321578 .flake8
--- /dev/null Thu Jan 01 00:00:00 1970 +0000
+++ b/.flake8 Sun Mar 01 12:33:51 2020 +0100
@@ -0,0 +1,2 @@
+[flake8]
+ignore=E123,E124,E126,E128,W503
diff -r aa6c2b86af44 -r 78201a321578 __init__.py
--- a/__init__.py Mon Feb 17 11:43:33 2020 +0100
+++ b/__init__.py Sun Mar 01 12:33:51 2020 +0100
@@ -1,11 +1,11 @@
# This file is part of Tryton. The COPYRIGHT file at the top level of
# this repository contains the full copyright notices and license terms.
from trytond.pool import Pool
-from .payment import *
+from . import payment
def register():
Pool.register(
- Journal,
- Group,
+ payment.Journal,
+ payment.Group,
module='account_payment_sepa_cfonb', type_='model')
diff -r aa6c2b86af44 -r 78201a321578 payment.py
--- a/payment.py Mon Feb 17 11:43:33 2020 +0100
+++ b/payment.py Sun Mar 01 12:33:51 2020 +0100
@@ -9,9 +9,6 @@
from trytond.modules.account_payment_sepa import payment as sepa_payment
-__all__ = ['Journal', 'Group']
-
-
class Journal(metaclass=PoolMeta):
__name__ = 'account.payment.journal'
@@ -29,6 +26,7 @@
if flavor not in field.selection:
field.selection.append(flavor)
+
loader = genshi.template.TemplateLoader([
os.path.join(os.path.dirname(__file__), 'template'),
os.path.join(
diff -r aa6c2b86af44 -r 78201a321578 setup.py
--- a/setup.py Mon Feb 17 11:43:33 2020 +0100
+++ b/setup.py Sun Mar 01 12:33:51 2020 +0100
@@ -80,8 +80,8 @@
keywords='tryton account payment SEPA CFONB',
package_dir={'trytond.modules.account_payment_sepa_cfonb': '.'},
packages=(
- ['trytond.modules.account_payment_sepa_cfonb'] +
- ['trytond.modules.account_payment_sepa_cfonb.%s' % p
+ ['trytond.modules.account_payment_sepa_cfonb']
+ + ['trytond.modules.account_payment_sepa_cfonb.%s' % p
for p in find_packages()]
),
package_data={
@@ -96,7 +96,8 @@
'Intended Audience :: Developers',
'Intended Audience :: Financial and Insurance Industry',
'Intended Audience :: Legal Industry',
- 'License :: OSI Approved :: GNU General Public License v3 or later
(GPLv3+)',
+ 'License :: OSI Approved :: '
+ 'GNU General Public License v3 or later (GPLv3+)',
'Natural Language :: Bulgarian',
'Natural Language :: Catalan',
'Natural Language :: Chinese (Simplified)',
diff -r aa6c2b86af44 -r 78201a321578 tests/__init__.py
--- a/tests/__init__.py Mon Feb 17 11:43:33 2020 +0100
+++ b/tests/__init__.py Sun Mar 01 12:33:51 2020 +0100
@@ -2,7 +2,7 @@
# this repository contains the full copyright notices and license terms.
try:
- from
trytond.modules.account_payment_sepa_cfonb.tests.test_account_payment_sepa_cfonb
import suite
+ from
trytond.modules.account_payment_sepa_cfonb.tests.test_account_payment_sepa_cfonb
import suite # noqa: E501
except ImportError:
from .test_account_payment_sepa_cfonb import suite
