changeset 5a5a704ff435 in modules/analytic_sale:default
details:
https://hg.tryton.org/modules/analytic_sale?cmd=changeset;node=5a5a704ff435
description:
Fix flake8 errors and warnings
We add the flake8 configuration used so we ensure everyone uses the
same.
We remove the usage of __all__ for non public API.
When possible, we rationalize the class name according to its __name__
and module.
issue9082
review297061002
diffstat:
.flake8 | 2 ++
__init__.py | 6 +++---
sale.py | 8 +++-----
setup.py | 7 ++++---
4 files changed, 12 insertions(+), 11 deletions(-)
diffs (78 lines):
diff -r b05388864507 -r 5a5a704ff435 .flake8
--- /dev/null Thu Jan 01 00:00:00 1970 +0000
+++ b/.flake8 Sun Mar 01 12:33:52 2020 +0100
@@ -0,0 +1,2 @@
+[flake8]
+ignore=E123,E124,E126,E128,W503
diff -r b05388864507 -r 5a5a704ff435 __init__.py
--- a/__init__.py Wed Dec 04 11:09:35 2019 +0100
+++ b/__init__.py Sun Mar 01 12:33:52 2020 +0100
@@ -2,11 +2,11 @@
# this repository contains the full copyright notices and license terms.
from trytond.pool import Pool
-from .sale import *
+from . import sale
def register():
Pool.register(
- SaleLine,
- AnalyticAccountEntry,
+ sale.Line,
+ sale.AnalyticAccountEntry,
module='analytic_sale', type_='model')
diff -r b05388864507 -r 5a5a704ff435 sale.py
--- a/sale.py Wed Dec 04 11:09:35 2019 +0100
+++ b/sale.py Sun Mar 01 12:33:52 2020 +0100
@@ -6,15 +6,13 @@
from trytond.modules.analytic_account import AnalyticMixin
-__all__ = ['SaleLine', 'AnalyticAccountEntry']
-
-class SaleLine(AnalyticMixin, metaclass=PoolMeta):
+class Line(AnalyticMixin, metaclass=PoolMeta):
__name__ = 'sale.line'
@classmethod
def __setup__(cls):
- super(SaleLine, cls).__setup__()
+ super().__setup__()
cls.analytic_accounts.domain = [
('company', '=', If(~Eval('_parent_sale', {}),
Eval('context', {}).get('company', -1),
@@ -30,7 +28,7 @@
pool = Pool()
AnalyticAccountEntry = pool.get('analytic.account.entry')
- invoice_lines = super(SaleLine, self).get_invoice_line()
+ invoice_lines = super().get_invoice_line()
for invoice_line in invoice_lines:
new_entries = AnalyticAccountEntry.copy(self.analytic_accounts,
default={
diff -r b05388864507 -r 5a5a704ff435 setup.py
--- a/setup.py Wed Dec 04 11:09:35 2019 +0100
+++ b/setup.py Sun Mar 01 12:33:52 2020 +0100
@@ -79,8 +79,8 @@
keywords='tryton analytic account sale',
package_dir={'trytond.modules.analytic_sale': '.'},
packages=(
- ['trytond.modules.analytic_sale'] +
- ['trytond.modules.analytic_sale.%s' % p for p in find_packages()]
+ ['trytond.modules.analytic_sale']
+ + ['trytond.modules.analytic_sale.%s' % p for p in find_packages()]
),
package_data={
'trytond.modules.analytic_sale': (info.get('xml', [])
@@ -93,7 +93,8 @@
'Intended Audience :: Developers',
'Intended Audience :: Financial and Insurance Industry',
'Intended Audience :: Legal Industry',
- 'License :: OSI Approved :: GNU General Public License v3 or later
(GPLv3+)',
+ 'License :: OSI Approved :: '
+ 'GNU General Public License v3 or later (GPLv3+)',
'Natural Language :: Bulgarian',
'Natural Language :: Catalan',
'Natural Language :: Chinese (Simplified)',
