changeset c6ab75c0376d in modules/account_stock_landed_cost_weight:default
details:
https://hg.tryton.org/modules/account_stock_landed_cost_weight?cmd=changeset;node=c6ab75c0376d
description:
Fix flake8 errors and warnings
We add the flake8 configuration used so we ensure everyone uses the
same.
We remove the usage of __all__ for non public API.
When possible, we rationalize the class name according to its __name__
and module.
issue9082
review297061002
diffstat:
.flake8 | 2 ++
__init__.py | 4 ++--
account.py | 2 --
setup.py | 9 +++++----
tests/__init__.py | 2 +-
5 files changed, 10 insertions(+), 9 deletions(-)
diffs (79 lines):
diff -r 6d701546506c -r c6ab75c0376d .flake8
--- /dev/null Thu Jan 01 00:00:00 1970 +0000
+++ b/.flake8 Sun Mar 01 12:33:51 2020 +0100
@@ -0,0 +1,2 @@
+[flake8]
+ignore=E123,E124,E126,E128,W503
diff -r 6d701546506c -r c6ab75c0376d __init__.py
--- a/__init__.py Wed Dec 04 11:09:35 2019 +0100
+++ b/__init__.py Sun Mar 01 12:33:51 2020 +0100
@@ -2,10 +2,10 @@
# this repository contains the full copyright notices and license terms.
from trytond.pool import Pool
-from .account import *
+from . import account
def register():
Pool.register(
- LandedCost,
+ account.LandedCost,
module='account_stock_landed_cost_weight', type_='model')
diff -r 6d701546506c -r c6ab75c0376d account.py
--- a/account.py Wed Dec 04 11:09:35 2019 +0100
+++ b/account.py Sun Mar 01 12:33:51 2020 +0100
@@ -4,8 +4,6 @@
from trytond.pool import PoolMeta
-__all__ = ['LandedCost']
-
class LandedCost(metaclass=PoolMeta):
__name__ = 'account.landed_cost'
diff -r 6d701546506c -r c6ab75c0376d setup.py
--- a/setup.py Wed Dec 04 11:09:35 2019 +0100
+++ b/setup.py Sun Mar 01 12:33:51 2020 +0100
@@ -80,8 +80,8 @@
keywords='tryton account stock valuation landed cost weight',
package_dir={'trytond.modules.account_stock_landed_cost_weight': '.'},
packages=(
- ['trytond.modules.account_stock_landed_cost_weight'] +
- ['trytond.modules.account_stock_landed_cost_weight.%s' % p
+ ['trytond.modules.account_stock_landed_cost_weight']
+ + ['trytond.modules.account_stock_landed_cost_weight.%s' % p
for p in find_packages()]
),
package_data={
@@ -96,7 +96,8 @@
'Intended Audience :: Developers',
'Intended Audience :: Financial and Insurance Industry',
'Intended Audience :: Legal Industry',
- 'License :: OSI Approved :: GNU General Public License v3 or later
(GPLv3+)',
+ 'License :: OSI Approved :: '
+ 'GNU General Public License v3 or later (GPLv3+)',
'Natural Language :: Bulgarian',
'Natural Language :: Catalan',
'Natural Language :: Chinese (Simplified)',
@@ -134,7 +135,7 @@
entry_points="""
[trytond.modules]
account_stock_landed_cost_weight =
trytond.modules.account_stock_landed_cost_weight
- """,
+ """, # noqa: E501
test_suite='tests',
test_loader='trytond.test_loader:Loader',
tests_require=tests_require,
diff -r 6d701546506c -r c6ab75c0376d tests/__init__.py
--- a/tests/__init__.py Wed Dec 04 11:09:35 2019 +0100
+++ b/tests/__init__.py Sun Mar 01 12:33:51 2020 +0100
@@ -2,7 +2,7 @@
# this repository contains the full copyright notices and license terms.
try:
- from
trytond.modules.account_stock_landed_cost_weight.tests.test_account_stock_landed_cost_weight
import suite
+ from
trytond.modules.account_stock_landed_cost_weight.tests.test_account_stock_landed_cost_weight
import suite # noqa: E501
except ImportError:
from .test_account_stock_landed_cost_weight import suite
