changeset d727a671d928 in modules/carrier_percentage:default
details:
https://hg.tryton.org/modules/carrier_percentage?cmd=changeset;node=d727a671d928
description:
Fix flake8 errors and warnings
We add the flake8 configuration used so we ensure everyone uses the
same.
We remove the usage of __all__ for non public API.
When possible, we rationalize the class name according to its __name__
and module.
issue9082
review297061002
diffstat:
.flake8 | 2 ++
carrier.py | 2 --
sale.py | 2 --
setup.py | 8 +++++---
stock.py | 2 --
tests/__init__.py | 2 +-
6 files changed, 8 insertions(+), 10 deletions(-)
diffs (79 lines):
diff -r dd524775e385 -r d727a671d928 .flake8
--- /dev/null Thu Jan 01 00:00:00 1970 +0000
+++ b/.flake8 Sun Mar 01 12:33:52 2020 +0100
@@ -0,0 +1,2 @@
+[flake8]
+ignore=E123,E124,E126,E128,W503
diff -r dd524775e385 -r d727a671d928 carrier.py
--- a/carrier.py Wed Dec 04 11:09:35 2019 +0100
+++ b/carrier.py Sun Mar 01 12:33:52 2020 +0100
@@ -6,8 +6,6 @@
from trytond.pool import Pool, PoolMeta
from trytond.pyson import Eval
-__all__ = ['Carrier']
-
class Carrier(metaclass=PoolMeta):
__name__ = 'carrier'
diff -r dd524775e385 -r d727a671d928 sale.py
--- a/sale.py Wed Dec 04 11:09:35 2019 +0100
+++ b/sale.py Sun Mar 01 12:33:52 2020 +0100
@@ -4,8 +4,6 @@
from trytond.pool import PoolMeta
-__all__ = ['Sale']
-
class Sale(metaclass=PoolMeta):
__name__ = 'sale.sale'
diff -r dd524775e385 -r d727a671d928 setup.py
--- a/setup.py Wed Dec 04 11:09:35 2019 +0100
+++ b/setup.py Sun Mar 01 12:33:52 2020 +0100
@@ -81,8 +81,9 @@
keywords='tryton carrier percentage',
package_dir={'trytond.modules.carrier_percentage': '.'},
packages=(
- ['trytond.modules.carrier_percentage'] +
- ['trytond.modules.carrier_percentage.%s' % p for p in find_packages()]
+ ['trytond.modules.carrier_percentage']
+ + ['trytond.modules.carrier_percentage.%s' % p
+ for p in find_packages()]
),
package_data={
'trytond.modules.carrier_percentage': (info.get('xml', [])
@@ -96,7 +97,8 @@
'Intended Audience :: Financial and Insurance Industry',
'Intended Audience :: Legal Industry',
'Intended Audience :: Manufacturing',
- 'License :: OSI Approved :: GNU General Public License v3 or later
(GPLv3+)',
+ 'License :: OSI Approved :: '
+ 'GNU General Public License v3 or later (GPLv3+)',
'Natural Language :: Bulgarian',
'Natural Language :: Catalan',
'Natural Language :: Chinese (Simplified)',
diff -r dd524775e385 -r d727a671d928 stock.py
--- a/stock.py Wed Dec 04 11:09:35 2019 +0100
+++ b/stock.py Sun Mar 01 12:33:52 2020 +0100
@@ -5,8 +5,6 @@
from trytond.pool import Pool, PoolMeta
from trytond.transaction import Transaction
-__all__ = ['ShipmentIn', 'ShipmentOut']
-
def _percentage_amount(lines, company):
pool = Pool()
diff -r dd524775e385 -r d727a671d928 tests/__init__.py
--- a/tests/__init__.py Wed Dec 04 11:09:35 2019 +0100
+++ b/tests/__init__.py Sun Mar 01 12:33:52 2020 +0100
@@ -2,7 +2,7 @@
# this repository contains the full copyright notices and license terms.
try:
- from trytond.modules.carrier_percentage.tests.test_carrier_percentage
import suite
+ from trytond.modules.carrier_percentage.tests.test_carrier_percentage
import suite # noqa: E501
except ImportError:
from .test_carrier_percentage import suite
