changeset f851cac6bf95 in modules/notification_email:default
details:
https://hg.tryton.org/modules/notification_email?cmd=changeset;node=f851cac6bf95
description:
Fix flake8 errors and warnings
We add the flake8 configuration used so we ensure everyone uses the
same.
We remove the usage of __all__ for non public API.
When possible, we rationalize the class name according to its __name__
and module.
issue9082
review297061002
diffstat:
.flake8 | 2 ++
ir.py | 2 --
notification.py | 1 -
setup.py | 8 +++++---
4 files changed, 7 insertions(+), 6 deletions(-)
diffs (54 lines):
diff -r 2e6d46585d1f -r f851cac6bf95 .flake8
--- /dev/null Thu Jan 01 00:00:00 1970 +0000
+++ b/.flake8 Sun Mar 01 12:33:52 2020 +0100
@@ -0,0 +1,2 @@
+[flake8]
+ignore=E123,E124,E126,E128,W503
diff -r 2e6d46585d1f -r f851cac6bf95 ir.py
--- a/ir.py Sat Feb 22 15:11:06 2020 +0100
+++ b/ir.py Sun Mar 01 12:33:52 2020 +0100
@@ -4,8 +4,6 @@
from trytond.pool import Pool, PoolMeta
from trytond.pyson import Eval
-__all__ = ['Trigger']
-
class Trigger(metaclass=PoolMeta):
__name__ = 'ir.trigger'
diff -r 2e6d46585d1f -r f851cac6bf95 notification.py
--- a/notification.py Sat Feb 22 15:11:06 2020 +0100
+++ b/notification.py Sun Mar 01 12:33:52 2020 +0100
@@ -16,7 +16,6 @@
from trytond.sendmail import sendmail_transactional, SMTPDataManager
from trytond.transaction import Transaction
-__all__ = ['Email', 'EmailAttachment', 'EmailLog']
_EMAIL_MODELS = [
'res.user',
'party.party',
diff -r 2e6d46585d1f -r f851cac6bf95 setup.py
--- a/setup.py Sat Feb 22 15:11:06 2020 +0100
+++ b/setup.py Sun Mar 01 12:33:52 2020 +0100
@@ -79,8 +79,9 @@
keywords='tryton email notification',
package_dir={'trytond.modules.notification_email': '.'},
packages=(
- ['trytond.modules.notification_email'] +
- ['trytond.modules.notification_email.%s' % p for p in find_packages()]
+ ['trytond.modules.notification_email']
+ + ['trytond.modules.notification_email.%s' % p
+ for p in find_packages()]
),
package_data={
'trytond.modules.notification_email': (info.get('xml', [])
@@ -92,7 +93,8 @@
'Environment :: Plugins',
'Framework :: Tryton',
'Intended Audience :: Developers',
- 'License :: OSI Approved :: GNU General Public License v3 or later
(GPLv3+)',
+ 'License :: OSI Approved :: '
+ 'GNU General Public License v3 or later (GPLv3+)',
'Natural Language :: Bulgarian',
'Natural Language :: Catalan',
'Natural Language :: Chinese (Simplified)',
