changeset 08e95c07b1c4 in modules/currency:default
details: https://hg.tryton.org/modules/currency?cmd=changeset;node=08e95c07b1c4
description:
Fix flake8 errors and warnings
We add the flake8 configuration used so we ensure everyone uses the
same.
We remove the usage of __all__ for non public API.
When possible, we rationalize the class name according to its __name__
and module.
issue9082
review297061002
diffstat:
.flake8 | 2 ++
__init__.py | 6 +++---
currency.py | 8 +++-----
setup.py | 9 +++++----
4 files changed, 13 insertions(+), 12 deletions(-)
diffs (89 lines):
diff -r 9b47abc0207f -r 08e95c07b1c4 .flake8
--- /dev/null Thu Jan 01 00:00:00 1970 +0000
+++ b/.flake8 Sun Mar 01 12:33:52 2020 +0100
@@ -0,0 +1,2 @@
+[flake8]
+ignore=E123,E124,E126,E128,W503
diff -r 9b47abc0207f -r 08e95c07b1c4 __init__.py
--- a/__init__.py Wed Dec 04 11:09:35 2019 +0100
+++ b/__init__.py Sun Mar 01 12:33:52 2020 +0100
@@ -2,11 +2,11 @@
# this repository contains the full copyright notices and license terms.
from trytond.pool import Pool
-from .currency import *
+from . import currency
def register():
Pool.register(
- Currency,
- Rate,
+ currency.Currency,
+ currency.CurrencyRate,
module='currency', type_='model')
diff -r 9b47abc0207f -r 08e95c07b1c4 currency.py
--- a/currency.py Wed Dec 04 11:09:35 2019 +0100
+++ b/currency.py Sun Mar 01 12:33:52 2020 +0100
@@ -17,8 +17,6 @@
from .exceptions import RateError
-__all__ = ['Currency', 'Rate']
-
class Currency(DeactivableMixin, ModelSQL, ModelView):
'Currency'
@@ -223,8 +221,8 @@
return query
-class Rate(ModelSQL, ModelView):
- 'Rate'
+class CurrencyRate(ModelSQL, ModelView):
+ "Currency Rate"
__name__ = 'currency.currency.rate'
date = fields.Date('Date', required=True, select=True,
help="From when the rate applies.")
@@ -236,7 +234,7 @@
@classmethod
def __setup__(cls):
- super(Rate, cls).__setup__()
+ super().__setup__()
t = cls.__table__()
cls._sql_constraints = [
('date_currency_uniq', Unique(t, t.date, t.currency),
diff -r 9b47abc0207f -r 08e95c07b1c4 setup.py
--- a/setup.py Wed Dec 04 11:09:35 2019 +0100
+++ b/setup.py Sun Mar 01 12:33:52 2020 +0100
@@ -79,8 +79,8 @@
keywords='tryton currency',
package_dir={'trytond.modules.currency': '.'},
packages=(
- ['trytond.modules.currency'] +
- ['trytond.modules.currency.%s' % p for p in find_packages()]
+ ['trytond.modules.currency']
+ + ['trytond.modules.currency.%s' % p for p in find_packages()]
),
package_data={
'trytond.modules.currency': (info.get('xml', [])
@@ -95,7 +95,8 @@
'Intended Audience :: Financial and Insurance Industry',
'Intended Audience :: Legal Industry',
'Intended Audience :: Manufacturing',
- 'License :: OSI Approved :: GNU General Public License v3 or later
(GPLv3+)',
+ 'License :: OSI Approved :: '
+ 'GNU General Public License v3 or later (GPLv3+)',
'Natural Language :: Bulgarian',
'Natural Language :: Catalan',
'Natural Language :: Chinese (Simplified)',
@@ -139,7 +140,7 @@
currency = trytond.modules.currency
[console_scripts]
trytond_import_currencies =
trytond.modules.currency.scripts.import_currencies:run [data]
- """,
+ """, # noqa: E501
test_suite='tests',
test_loader='trytond.test_loader:Loader',
tests_require=tests_require,
