changeset a5a2c32a68ca in modules/product_cost_fifo:default
details:
https://hg.tryton.org/modules/product_cost_fifo?cmd=changeset;node=a5a2c32a68ca
description:
Fix flake8 errors and warnings
We add the flake8 configuration used so we ensure everyone uses the
same.
We remove the usage of __all__ for non public API.
When possible, we rationalize the class name according to its __name__
and module.
issue9082
review297061002
diffstat:
.flake8 | 2 ++
__init__.py | 10 +++++-----
move.py | 2 --
product.py | 2 --
setup.py | 7 ++++---
tests/__init__.py | 2 +-
6 files changed, 12 insertions(+), 13 deletions(-)
diffs (88 lines):
diff -r 1635dd7c1f7f -r a5a2c32a68ca .flake8
--- /dev/null Thu Jan 01 00:00:00 1970 +0000
+++ b/.flake8 Sun Mar 01 12:33:52 2020 +0100
@@ -0,0 +1,2 @@
+[flake8]
+ignore=E123,E124,E126,E128,W503
diff -r 1635dd7c1f7f -r a5a2c32a68ca __init__.py
--- a/__init__.py Sun Jan 26 21:10:40 2020 +0100
+++ b/__init__.py Sun Mar 01 12:33:52 2020 +0100
@@ -1,13 +1,13 @@
# This file is part of Tryton. The COPYRIGHT file at the top level of
# this repository contains the full copyright notices and license terms.
from trytond.pool import Pool
-from .product import *
-from .move import *
+from . import product
+from . import move
def register():
Pool.register(
- Template,
- Product,
- Move,
+ product.Template,
+ product.Product,
+ move.Move,
module='product_cost_fifo', type_='model')
diff -r 1635dd7c1f7f -r a5a2c32a68ca move.py
--- a/move.py Sun Jan 26 21:10:40 2020 +0100
+++ b/move.py Sun Mar 01 12:33:52 2020 +0100
@@ -10,8 +10,6 @@
from trytond.pool import Pool, PoolMeta
from trytond.transaction import Transaction
-__all__ = ['Move']
-
class Move(metaclass=PoolMeta):
__name__ = 'stock.move'
diff -r 1635dd7c1f7f -r a5a2c32a68ca product.py
--- a/product.py Sun Jan 26 21:10:40 2020 +0100
+++ b/product.py Sun Mar 01 12:33:52 2020 +0100
@@ -7,8 +7,6 @@
from trytond.transaction import Transaction
from trytond.pool import Pool, PoolMeta
-__all__ = ['Template', 'Product']
-
class Template(metaclass=PoolMeta):
__name__ = 'product.template'
diff -r 1635dd7c1f7f -r a5a2c32a68ca setup.py
--- a/setup.py Sun Jan 26 21:10:40 2020 +0100
+++ b/setup.py Sun Mar 01 12:33:52 2020 +0100
@@ -79,8 +79,8 @@
keywords='tryton product cost fifo',
package_dir={'trytond.modules.product_cost_fifo': '.'},
packages=(
- ['trytond.modules.product_cost_fifo'] +
- ['trytond.modules.product_cost_fifo.%s' % p for p in find_packages()]
+ ['trytond.modules.product_cost_fifo']
+ + ['trytond.modules.product_cost_fifo.%s' % p for p in find_packages()]
),
package_data={
'trytond.modules.product_cost_fifo': (info.get('xml', [])
@@ -95,7 +95,8 @@
'Intended Audience :: Financial and Insurance Industry',
'Intended Audience :: Legal Industry',
'Intended Audience :: Manufacturing',
- 'License :: OSI Approved :: GNU General Public License v3 or later
(GPLv3+)',
+ 'License :: OSI Approved :: '
+ 'GNU General Public License v3 or later (GPLv3+)',
'Natural Language :: Bulgarian',
'Natural Language :: Catalan',
'Natural Language :: Chinese (Simplified)',
diff -r 1635dd7c1f7f -r a5a2c32a68ca tests/__init__.py
--- a/tests/__init__.py Sun Jan 26 21:10:40 2020 +0100
+++ b/tests/__init__.py Sun Mar 01 12:33:52 2020 +0100
@@ -2,7 +2,7 @@
# this repository contains the full copyright notices and license terms.
try:
- from trytond.modules.product_cost_fifo.tests.test_product_cost_fifo import
suite
+ from trytond.modules.product_cost_fifo.tests.test_product_cost_fifo import
suite # noqa: E501
except ImportError:
from .test_product_cost_fifo import suite
