changeset 6ca36731a428 in modules/product_measurements:default
details:
https://hg.tryton.org/modules/product_measurements?cmd=changeset;node=6ca36731a428
description:
Fix flake8 errors and warnings
We add the flake8 configuration used so we ensure everyone uses the
same.
We remove the usage of __all__ for non public API.
When possible, we rationalize the class name according to its __name__
and module.
issue9082
review297061002
diffstat:
.flake8 | 2 ++
product.py | 2 --
setup.py | 7 ++++---
tests/__init__.py | 2 +-
4 files changed, 7 insertions(+), 6 deletions(-)
diffs (54 lines):
diff -r 7c9355fa65f4 -r 6ca36731a428 .flake8
--- /dev/null Thu Jan 01 00:00:00 1970 +0000
+++ b/.flake8 Sun Mar 01 12:33:52 2020 +0100
@@ -0,0 +1,2 @@
+[flake8]
+ignore=E123,E124,E126,E128,W503
diff -r 7c9355fa65f4 -r 6ca36731a428 product.py
--- a/product.py Wed Dec 04 11:09:36 2019 +0100
+++ b/product.py Sun Mar 01 12:33:52 2020 +0100
@@ -4,8 +4,6 @@
from trytond.pyson import Eval, Bool, Id
from trytond.pool import PoolMeta, Pool
-__all__ = ['Template', 'Product']
-
NON_MEASURABLE = ['service']
diff -r 7c9355fa65f4 -r 6ca36731a428 setup.py
--- a/setup.py Wed Dec 04 11:09:36 2019 +0100
+++ b/setup.py Sun Mar 01 12:33:52 2020 +0100
@@ -78,8 +78,8 @@
keywords='tryton product measurement',
package_dir={'trytond.modules.product_measurements': '.'},
packages=(
- ['trytond.modules.product_measurements'] +
- ['trytond.modules.product_measurements.%s' % p
+ ['trytond.modules.product_measurements']
+ + ['trytond.modules.product_measurements.%s' % p
for p in find_packages()]
),
package_data={
@@ -94,7 +94,8 @@
'Intended Audience :: Financial and Insurance Industry',
'Intended Audience :: Legal Industry',
'Intended Audience :: Manufacturing',
- 'License :: OSI Approved :: GNU General Public License v3 or later
(GPLv3+)',
+ 'License :: OSI Approved :: '
+ 'GNU General Public License v3 or later (GPLv3+)',
'Natural Language :: Bulgarian',
'Natural Language :: Catalan',
'Natural Language :: Chinese (Simplified)',
diff -r 7c9355fa65f4 -r 6ca36731a428 tests/__init__.py
--- a/tests/__init__.py Wed Dec 04 11:09:36 2019 +0100
+++ b/tests/__init__.py Sun Mar 01 12:33:52 2020 +0100
@@ -2,7 +2,7 @@
# this repository contains the full copyright notices and license terms.
try:
- from trytond.modules.product_measurements.tests.test_product_measurements
import suite
+ from trytond.modules.product_measurements.tests.test_product_measurements
import suite # noqa: E501
except ImportError:
from .test_product_measurements import suite
