changeset 2fe65748bc4f in modules/project_revenue:default
details:
https://hg.tryton.org/modules/project_revenue?cmd=changeset;node=2fe65748bc4f
description:
Fix flake8 errors and warnings
We add the flake8 configuration used so we ensure everyone uses the
same.
We remove the usage of __all__ for non public API.
When possible, we rationalize the class name according to its __name__
and module.
issue9082
review297061002
diffstat:
.flake8 | 2 ++
__init__.py | 2 +-
purchase.py | 4 +---
setup.py | 7 ++++---
tests/__init__.py | 2 +-
work.py | 2 --
6 files changed, 9 insertions(+), 10 deletions(-)
diffs (80 lines):
diff -r bbfcb2947963 -r 2fe65748bc4f .flake8
--- /dev/null Thu Jan 01 00:00:00 1970 +0000
+++ b/.flake8 Sun Mar 01 12:33:53 2020 +0100
@@ -0,0 +1,2 @@
+[flake8]
+ignore=E123,E124,E126,E128,W503
diff -r bbfcb2947963 -r 2fe65748bc4f __init__.py
--- a/__init__.py Wed Dec 04 11:09:36 2019 +0100
+++ b/__init__.py Sun Mar 01 12:33:53 2020 +0100
@@ -11,6 +11,6 @@
work.Work,
module='project_revenue', type_='model')
Pool.register(
- purchase.PurchaseLine,
+ purchase.Line,
module='project_revenue', type_='model',
depends=['purchase'])
diff -r bbfcb2947963 -r 2fe65748bc4f purchase.py
--- a/purchase.py Wed Dec 04 11:09:36 2019 +0100
+++ b/purchase.py Sun Mar 01 12:33:53 2020 +0100
@@ -4,10 +4,8 @@
from trytond.model import fields
from trytond.pyson import Eval
-__all__ = ['PurchaseLine']
-
-class PurchaseLine(metaclass=PoolMeta):
+class Line(metaclass=PoolMeta):
__name__ = 'purchase.line'
work = fields.Many2One('project.work', 'Work Effort', select=True,
diff -r bbfcb2947963 -r 2fe65748bc4f setup.py
--- a/setup.py Wed Dec 04 11:09:36 2019 +0100
+++ b/setup.py Sun Mar 01 12:33:53 2020 +0100
@@ -80,8 +80,8 @@
keywords='tryton project revenue',
package_dir={'trytond.modules.project_revenue': '.'},
packages=(
- ['trytond.modules.project_revenue'] +
- ['trytond.modules.project_revenue.%s' % p for p in find_packages()]
+ ['trytond.modules.project_revenue']
+ + ['trytond.modules.project_revenue.%s' % p for p in find_packages()]
),
package_data={
'trytond.modules.project_revenue': (info.get('xml', [])
@@ -95,7 +95,8 @@
'Intended Audience :: Financial and Insurance Industry',
'Intended Audience :: Legal Industry',
'Intended Audience :: Manufacturing',
- 'License :: OSI Approved :: GNU General Public License v3 or later
(GPLv3+)',
+ 'License :: OSI Approved :: '
+ 'GNU General Public License v3 or later (GPLv3+)',
'Natural Language :: Bulgarian',
'Natural Language :: Catalan',
'Natural Language :: Chinese (Simplified)',
diff -r bbfcb2947963 -r 2fe65748bc4f tests/__init__.py
--- a/tests/__init__.py Wed Dec 04 11:09:36 2019 +0100
+++ b/tests/__init__.py Sun Mar 01 12:33:53 2020 +0100
@@ -2,7 +2,7 @@
# this repository contains the full copyright notices and license terms.
try:
- from trytond.modules.project_revenue.tests.test_project_revenue import
suite
+ from trytond.modules.project_revenue.tests.test_project_revenue import
suite # noqa: E501
except ImportError:
from .test_project_revenue import suite
diff -r bbfcb2947963 -r 2fe65748bc4f work.py
--- a/work.py Wed Dec 04 11:09:36 2019 +0100
+++ b/work.py Sun Mar 01 12:33:53 2020 +0100
@@ -14,8 +14,6 @@
from trytond.modules.product import price_digits
-__all__ = ['Work']
-
class Work(metaclass=PoolMeta):
__name__ = 'project.work'
