changeset 8a106c1ca17b in modules/production_work:default
details:
https://hg.tryton.org/modules/production_work?cmd=changeset;node=8a106c1ca17b
description:
Fix flake8 errors and warnings
We add the flake8 configuration used so we ensure everyone uses the
same.
We remove the usage of __all__ for non public API.
When possible, we rationalize the class name according to its __name__
and module.
issue9082
review297061002
diffstat:
.flake8 | 2 ++
__init__.py | 20 ++++++++++----------
production.py | 2 --
routing.py | 2 --
setup.py | 7 ++++---
tests/__init__.py | 2 +-
work.py | 2 --
7 files changed, 17 insertions(+), 20 deletions(-)
diffs (110 lines):
diff -r 427fbb071ea1 -r 8a106c1ca17b .flake8
--- /dev/null Thu Jan 01 00:00:00 1970 +0000
+++ b/.flake8 Sun Mar 01 12:33:53 2020 +0100
@@ -0,0 +1,2 @@
+[flake8]
+ignore=E123,E124,E126,E128,W503
diff -r 427fbb071ea1 -r 8a106c1ca17b __init__.py
--- a/__init__.py Wed Dec 18 09:25:12 2019 +0100
+++ b/__init__.py Sun Mar 01 12:33:53 2020 +0100
@@ -2,18 +2,18 @@
# this repository contains the full copyright notices and license terms.
from trytond.pool import Pool
-from .work import *
-from .routing import *
-from .production import *
+from . import work
+from . import routing
+from . import production
def register():
Pool.register(
- WorkCenterCategory,
- WorkCenter,
- Work,
- WorkCycle,
- Operation,
- RoutingStep,
- Production,
+ work.WorkCenterCategory,
+ work.WorkCenter,
+ work.Work,
+ work.WorkCycle,
+ routing.Operation,
+ routing.RoutingStep,
+ production.Production,
module='production_work', type_='model')
diff -r 427fbb071ea1 -r 8a106c1ca17b production.py
--- a/production.py Wed Dec 18 09:25:12 2019 +0100
+++ b/production.py Sun Mar 01 12:33:53 2020 +0100
@@ -11,8 +11,6 @@
from trytond.pyson import Eval, Bool
from trytond.transaction import Transaction
-__all__ = ['Production']
-
class Production(metaclass=PoolMeta):
__name__ = 'production'
diff -r 427fbb071ea1 -r 8a106c1ca17b routing.py
--- a/routing.py Wed Dec 18 09:25:12 2019 +0100
+++ b/routing.py Sun Mar 01 12:33:53 2020 +0100
@@ -3,8 +3,6 @@
from trytond.pool import PoolMeta, Pool
from trytond.model import fields
-__all__ = ['Operation', 'RoutingStep']
-
class Operation(metaclass=PoolMeta):
__name__ = 'production.routing.operation'
diff -r 427fbb071ea1 -r 8a106c1ca17b setup.py
--- a/setup.py Wed Dec 18 09:25:12 2019 +0100
+++ b/setup.py Sun Mar 01 12:33:53 2020 +0100
@@ -79,8 +79,8 @@
keywords='tryton production work',
package_dir={'trytond.modules.production_work': '.'},
packages=(
- ['trytond.modules.production_work'] +
- ['trytond.modules.production_work.%s' % p for p in find_packages()]
+ ['trytond.modules.production_work']
+ + ['trytond.modules.production_work.%s' % p for p in find_packages()]
),
package_data={
'trytond.modules.production_work': (info.get('xml', [])
@@ -94,7 +94,8 @@
'Intended Audience :: Financial and Insurance Industry',
'Intended Audience :: Legal Industry',
'Intended Audience :: Manufacturing',
- 'License :: OSI Approved :: GNU General Public License v3 or later
(GPLv3+)',
+ 'License :: OSI Approved :: '
+ 'GNU General Public License v3 or later (GPLv3+)',
'Natural Language :: Bulgarian',
'Natural Language :: Catalan',
'Natural Language :: Chinese (Simplified)',
diff -r 427fbb071ea1 -r 8a106c1ca17b tests/__init__.py
--- a/tests/__init__.py Wed Dec 18 09:25:12 2019 +0100
+++ b/tests/__init__.py Sun Mar 01 12:33:53 2020 +0100
@@ -2,7 +2,7 @@
# this repository contains the full copyright notices and license terms.
try:
- from trytond.modules.production_work.tests.test_production_work import
suite
+ from trytond.modules.production_work.tests.test_production_work import
suite # noqa: E501
except ImportError:
from .test_production_work import suite
diff -r 427fbb071ea1 -r 8a106c1ca17b work.py
--- a/work.py Wed Dec 18 09:25:12 2019 +0100
+++ b/work.py Sun Mar 01 12:33:53 2020 +0100
@@ -17,8 +17,6 @@
from trytond.modules.product import price_digits
from .exceptions import PickerError
-__all__ = ['WorkCenterCategory', 'WorkCenter', 'Work', 'WorkCycle']
-
class WorkCenterCategory(ModelSQL, ModelView):
'Work Center Category'
