changeset d7120eb005b1 in modules/product_price_list:default
details:
https://hg.tryton.org/modules/product_price_list?cmd=changeset;node=d7120eb005b1
description:
Fix flake8 errors and warnings
We add the flake8 configuration used so we ensure everyone uses the
same.
We remove the usage of __all__ for non public API.
When possible, we rationalize the class name according to its __name__
and module.
issue9082
review297061002
diffstat:
.flake8 | 2 ++
__init__.py | 6 +++---
price_list.py | 2 --
setup.py | 8 +++++---
tests/__init__.py | 2 +-
5 files changed, 11 insertions(+), 9 deletions(-)
diffs (73 lines):
diff -r 249a947bcecf -r d7120eb005b1 .flake8
--- /dev/null Thu Jan 01 00:00:00 1970 +0000
+++ b/.flake8 Sun Mar 01 12:33:52 2020 +0100
@@ -0,0 +1,2 @@
+[flake8]
+ignore=E123,E124,E126,E128,W503
diff -r 249a947bcecf -r d7120eb005b1 __init__.py
--- a/__init__.py Wed Dec 04 11:09:36 2019 +0100
+++ b/__init__.py Sun Mar 01 12:33:52 2020 +0100
@@ -1,11 +1,11 @@
# This file is part of Tryton. The COPYRIGHT file at the top level of
# this repository contains the full copyright notices and license terms.
from trytond.pool import Pool
-from .price_list import *
+from . import price_list
def register():
Pool.register(
- PriceList,
- PriceListLine,
+ price_list.PriceList,
+ price_list.PriceListLine,
module='product_price_list', type_='model')
diff -r 249a947bcecf -r d7120eb005b1 price_list.py
--- a/price_list.py Wed Dec 04 11:09:36 2019 +0100
+++ b/price_list.py Sun Mar 01 12:33:52 2020 +0100
@@ -14,8 +14,6 @@
from .exceptions import FormulaError
-__all__ = ['PriceList', 'PriceListLine']
-
class PriceList(DeactivableMixin, ModelSQL, ModelView):
'Price List'
diff -r 249a947bcecf -r d7120eb005b1 setup.py
--- a/setup.py Wed Dec 04 11:09:36 2019 +0100
+++ b/setup.py Sun Mar 01 12:33:52 2020 +0100
@@ -78,8 +78,9 @@
keywords='tryton product price list',
package_dir={'trytond.modules.product_price_list': '.'},
packages=(
- ['trytond.modules.product_price_list'] +
- ['trytond.modules.product_price_list.%s' % p for p in find_packages()]
+ ['trytond.modules.product_price_list']
+ + ['trytond.modules.product_price_list.%s' % p
+ for p in find_packages()]
),
package_data={
'trytond.modules.product_price_list': (info.get('xml', [])
@@ -92,7 +93,8 @@
'Intended Audience :: Developers',
'Intended Audience :: Financial and Insurance Industry',
'Intended Audience :: Legal Industry',
- 'License :: OSI Approved :: GNU General Public License v3 or later
(GPLv3+)',
+ 'License :: OSI Approved :: '
+ 'GNU General Public License v3 or later (GPLv3+)',
'Natural Language :: Bulgarian',
'Natural Language :: Catalan',
'Natural Language :: Chinese (Simplified)',
diff -r 249a947bcecf -r d7120eb005b1 tests/__init__.py
--- a/tests/__init__.py Wed Dec 04 11:09:36 2019 +0100
+++ b/tests/__init__.py Sun Mar 01 12:33:52 2020 +0100
@@ -2,7 +2,7 @@
# this repository contains the full copyright notices and license terms.
try:
- from trytond.modules.product_price_list.tests.test_product_price_list
import suite
+ from trytond.modules.product_price_list.tests.test_product_price_list
import suite # noqa: E501
except ImportError:
from .test_product_price_list import suite
