changeset a016f71b7ccb in modules/purchase_request_quotation:default
details:
https://hg.tryton.org/modules/purchase_request_quotation?cmd=changeset;node=a016f71b7ccb
description:
Fix flake8 errors and warnings
We add the flake8 configuration used so we ensure everyone uses the
same.
We remove the usage of __all__ for non public API.
When possible, we rationalize the class name according to its __name__
and module.
issue9082
review297061002
diffstat:
.flake8 | 2 ++
purchase.py | 10 ++--------
setup.py | 4 ++--
tests/__init__.py | 2 +-
4 files changed, 7 insertions(+), 11 deletions(-)
diffs (59 lines):
diff -r 622c9562d3c6 -r a016f71b7ccb .flake8
--- /dev/null Thu Jan 01 00:00:00 1970 +0000
+++ b/.flake8 Sun Mar 01 12:33:53 2020 +0100
@@ -0,0 +1,2 @@
+[flake8]
+ignore=E123,E124,E126,E128,W503
diff -r 622c9562d3c6 -r a016f71b7ccb purchase.py
--- a/purchase.py Wed Dec 04 11:09:36 2019 +0100
+++ b/purchase.py Sun Mar 01 12:33:53 2020 +0100
@@ -17,13 +17,6 @@
from .exceptions import PreviousQuotation
-__all__ = ['Configuration', 'ConfigurationSequence', 'Quotation',
- 'QuotationLine', 'CreatePurchaseRequestQuotationAskSuppliers',
- 'CreatePurchaseRequestQuotationSucceed', 'PurchaseRequest',
- 'CreatePurchaseRequestQuotation', 'CreatePurchase',
- 'PurchaseRequestQuotationReport']
-
-
def process_request(func):
@wraps(func)
def wrapper(cls, quotations):
@@ -625,7 +618,8 @@
to_save = []
requests = Request.browse(Transaction().context['active_ids'])
- reqs = [r for r in requests if not r.purchase_line and
r.quotation_lines]
+ reqs = [r for r in requests
+ if not r.purchase_line and r.quotation_lines]
to_save = []
for req in reqs:
if req.best_quotation_line:
diff -r 622c9562d3c6 -r a016f71b7ccb setup.py
--- a/setup.py Wed Dec 04 11:09:36 2019 +0100
+++ b/setup.py Sun Mar 01 12:33:53 2020 +0100
@@ -83,8 +83,8 @@
keywords='tryton purchase request for quotation',
package_dir={'trytond.modules.purchase_request_quotation': '.'},
packages=(
- ['trytond.modules.purchase_request_quotation'] +
- ['trytond.modules.purchase_request_quotation.%s' % p
+ ['trytond.modules.purchase_request_quotation']
+ + ['trytond.modules.purchase_request_quotation.%s' % p
for p in find_packages()]
),
package_data={
diff -r 622c9562d3c6 -r a016f71b7ccb tests/__init__.py
--- a/tests/__init__.py Wed Dec 04 11:09:36 2019 +0100
+++ b/tests/__init__.py Sun Mar 01 12:33:53 2020 +0100
@@ -3,7 +3,7 @@
# the full copyright notices and license terms.
try:
- from
trytond.modules.purchase_request_quotation.tests.test_purchase_request_quotation
import suite
+ from
trytond.modules.purchase_request_quotation.tests.test_purchase_request_quotation
import suite # noqa: E501
except ImportError:
from .test_purchase_request_quotation import suite
