changeset c9308d9bff3f in modules/sale_advance_payment:default
details:
https://hg.tryton.org/modules/sale_advance_payment?cmd=changeset;node=c9308d9bff3f
description:
Fix flake8 errors and warnings
We add the flake8 configuration used so we ensure everyone uses the
same.
We remove the usage of __all__ for non public API.
When possible, we rationalize the class name according to its __name__
and module.
issue9082
review297061002
diffstat:
.flake8 | 2 ++
sale.py | 9 ++-------
setup.py | 7 ++++---
stock.py | 2 --
tests/__init__.py | 2 +-
5 files changed, 9 insertions(+), 13 deletions(-)
diffs (76 lines):
diff -r 75a5c58c7bda -r c9308d9bff3f .flake8
--- /dev/null Thu Jan 01 00:00:00 1970 +0000
+++ b/.flake8 Sun Mar 01 12:33:53 2020 +0100
@@ -0,0 +1,2 @@
+[flake8]
+ignore=E123,E124,E126,E128,W503
diff -r 75a5c58c7bda -r c9308d9bff3f sale.py
--- a/sale.py Wed Dec 04 11:09:36 2019 +0100
+++ b/sale.py Sun Mar 01 12:33:53 2020 +0100
@@ -11,16 +11,11 @@
from trytond.pyson import Eval, Bool
from trytond.tools import decistmt
from trytond.transaction import Transaction
-from trytond.modules.company.model import CompanyMultiValueMixin,
CompanyValueMixin
+from trytond.modules.company.model import (
+ CompanyMultiValueMixin, CompanyValueMixin)
from .exceptions import FormulaError
-__all__ = [
- 'AdvancePaymentTerm', 'AdvancePaymentTermLine',
- 'AdvancePaymentTermLineAccount',
- 'AdvancePaymentCondition', 'Sale', 'SaleLine',
- 'HandleInvoiceException']
-
class AdvancePaymentTerm(
DeactivableMixin, ModelSQL, ModelView):
diff -r 75a5c58c7bda -r c9308d9bff3f setup.py
--- a/setup.py Wed Dec 04 11:09:36 2019 +0100
+++ b/setup.py Sun Mar 01 12:33:53 2020 +0100
@@ -81,8 +81,8 @@
keywords='tryton sale advance payment',
package_dir={'trytond.modules.sale_advance_payment': '.'},
packages=(
- ['trytond.modules.sale_advance_payment'] +
- ['trytond.modules.sale_advance_payment.%s' % p
+ ['trytond.modules.sale_advance_payment']
+ + ['trytond.modules.sale_advance_payment.%s' % p
for p in find_packages()]
),
package_data={
@@ -97,7 +97,8 @@
'Intended Audience :: Developers',
'Intended Audience :: Financial and Insurance Industry',
'Intended Audience :: Legal Industry',
- 'License :: OSI Approved :: GNU General Public License v3 or later
(GPLv3+)',
+ 'License :: OSI Approved :: '
+ 'GNU General Public License v3 or later (GPLv3+)',
'Natural Language :: Bulgarian',
'Natural Language :: Catalan',
'Natural Language :: Chinese (Simplified)',
diff -r 75a5c58c7bda -r c9308d9bff3f stock.py
--- a/stock.py Wed Dec 04 11:09:36 2019 +0100
+++ b/stock.py Sun Mar 01 12:33:53 2020 +0100
@@ -7,8 +7,6 @@
from .exceptions import ShippingBlocked
-__all__ = ['ShipmentOut']
-
class ShipmentOut(metaclass=PoolMeta):
__name__ = 'stock.shipment.out'
diff -r 75a5c58c7bda -r c9308d9bff3f tests/__init__.py
--- a/tests/__init__.py Wed Dec 04 11:09:36 2019 +0100
+++ b/tests/__init__.py Sun Mar 01 12:33:53 2020 +0100
@@ -2,7 +2,7 @@
# this repository contains the full copyright notices and license terms.
try:
- from trytond.modules.sale_advance_payment.tests.test_sale_advance_payment
import suite
+ from trytond.modules.sale_advance_payment.tests.test_sale_advance_payment
import suite # noqa: E501
except ImportError:
from .test_sale_advance_payment import suite
