changeset ba860aa9dd35 in modules/purchase_invoice_line_standalone:default
details:
https://hg.tryton.org/modules/purchase_invoice_line_standalone?cmd=changeset;node=ba860aa9dd35
description:
Fix flake8 errors and warnings
We add the flake8 configuration used so we ensure everyone uses the
same.
We remove the usage of __all__ for non public API.
When possible, we rationalize the class name according to its __name__
and module.
issue9082
review297061002
diffstat:
.flake8 | 2 ++
__init__.py | 8 ++++----
purchase.py | 3 ---
setup.py | 7 ++++---
tests/__init__.py | 2 +-
5 files changed, 11 insertions(+), 11 deletions(-)
diffs (77 lines):
diff -r 2941169448a7 -r ba860aa9dd35 .flake8
--- /dev/null Thu Jan 01 00:00:00 1970 +0000
+++ b/.flake8 Sun Mar 01 12:33:53 2020 +0100
@@ -0,0 +1,2 @@
+[flake8]
+ignore=E123,E124,E126,E128,W503
diff -r 2941169448a7 -r ba860aa9dd35 __init__.py
--- a/__init__.py Wed Dec 04 11:09:36 2019 +0100
+++ b/__init__.py Sun Mar 01 12:33:53 2020 +0100
@@ -2,14 +2,14 @@
# this repository contains the full copyright notices and license terms.
from trytond.pool import Pool
-from .purchase import *
+from . import purchase
def register():
Pool.register(
- Purchase,
- PurchaseIgnoredInvoiceLine,
+ purchase.Purchase,
+ purchase.PurchaseIgnoredInvoiceLine,
module='purchase_invoice_line_standalone', type_='model')
Pool.register(
- HandleInvoiceException,
+ purchase.HandleInvoiceException,
module='purchase_invoice_line_standalone', type_='wizard')
diff -r 2941169448a7 -r ba860aa9dd35 purchase.py
--- a/purchase.py Wed Dec 04 11:09:36 2019 +0100
+++ b/purchase.py Sun Mar 01 12:33:53 2020 +0100
@@ -4,9 +4,6 @@
from trytond.transaction import Transaction
from trytond.pool import Pool, PoolMeta
-__all__ = ['Purchase', 'PurchaseIgnoredInvoiceLine',
- 'HandleInvoiceException']
-
class Purchase(metaclass=PoolMeta):
__name__ = 'purchase.purchase'
diff -r 2941169448a7 -r ba860aa9dd35 setup.py
--- a/setup.py Wed Dec 04 11:09:36 2019 +0100
+++ b/setup.py Sun Mar 01 12:33:53 2020 +0100
@@ -80,8 +80,8 @@
keywords='tryton purchase standalone invoice line',
package_dir={'trytond.modules.purchase_invoice_line_standalone': '.'},
packages=(
- ['trytond.modules.purchase_invoice_line_standalone'] +
- ['trytond.modules.purchase_invoice_line_standalone.%s' % p
+ ['trytond.modules.purchase_invoice_line_standalone']
+ + ['trytond.modules.purchase_invoice_line_standalone.%s' % p
for p in find_packages()]
),
package_data={
@@ -96,7 +96,8 @@
'Intended Audience :: Developers',
'Intended Audience :: Legal Industry',
'Intended Audience :: Manufacturing',
- 'License :: OSI Approved :: GNU General Public License v3 or later
(GPLv3+)',
+ 'License :: OSI Approved :: '
+ 'GNU General Public License v3 or later (GPLv3+)',
'Natural Language :: Bulgarian',
'Natural Language :: Catalan',
'Natural Language :: Chinese (Simplified)',
diff -r 2941169448a7 -r ba860aa9dd35 tests/__init__.py
--- a/tests/__init__.py Wed Dec 04 11:09:36 2019 +0100
+++ b/tests/__init__.py Sun Mar 01 12:33:53 2020 +0100
@@ -2,7 +2,7 @@
# this repository contains the full copyright notices and license terms.
try:
- from
trytond.modules.purchase_invoice_line_standalone.tests.test_purchase_invoice_line_standalone
import suite
+ from
trytond.modules.purchase_invoice_line_standalone.tests.test_purchase_invoice_line_standalone
import suite # noqa: E501
except ImportError:
from .test_purchase_invoice_line_standalone import suite
