changeset a22017465760 in modules/sale_product_customer:default
details:
https://hg.tryton.org/modules/sale_product_customer?cmd=changeset;node=a22017465760
description:
Fix flake8 errors and warnings
We add the flake8 configuration used so we ensure everyone uses the
same.
We remove the usage of __all__ for non public API.
When possible, we rationalize the class name according to its __name__
and module.
issue9082
review297061002
diffstat:
.flake8 | 2 ++
sale.py | 2 +-
setup.py | 8 +++++---
tests/__init__.py | 2 +-
4 files changed, 9 insertions(+), 5 deletions(-)
diffs (55 lines):
diff -r e20e5091c81f -r a22017465760 .flake8
--- /dev/null Thu Jan 01 00:00:00 1970 +0000
+++ b/.flake8 Sun Mar 01 12:33:53 2020 +0100
@@ -0,0 +1,2 @@
+[flake8]
+ignore=E123,E124,E126,E128,W503
diff -r e20e5091c81f -r a22017465760 sale.py
--- a/sale.py Wed Dec 04 11:09:36 2019 +0100
+++ b/sale.py Sun Mar 01 12:33:53 2020 +0100
@@ -45,7 +45,7 @@
product_customers = list(self.product.product_customer_used(
**self._get_product_customer_pattern()))
if len(product_customers) == 1:
- self.product_customer, = product_customers
+ self.product_customer, = product_customers
elif (self.product_customer
and self.product_customer not in product_customers):
self.product_customer = None
diff -r e20e5091c81f -r a22017465760 setup.py
--- a/setup.py Wed Dec 04 11:09:36 2019 +0100
+++ b/setup.py Sun Mar 01 12:33:53 2020 +0100
@@ -80,8 +80,9 @@
keywords='tryton sale product customer',
package_dir={'trytond.modules.sale_product_customer': '.'},
packages=(
- ['trytond.modules.sale_product_customer'] +
- ['trytond.modules.sale_product_customer.%s' % p for p in
find_packages()]
+ ['trytond.modules.sale_product_customer']
+ + ['trytond.modules.sale_product_customer.%s' % p
+ for p in find_packages()]
),
package_data={
'trytond.modules.sale_product_customer': (info.get('xml', [])
@@ -95,7 +96,8 @@
'Intended Audience :: Developers',
'Intended Audience :: Financial and Insurance Industry',
'Intended Audience :: Legal Industry',
- 'License :: OSI Approved :: GNU General Public License v3 or later
(GPLv3+)',
+ 'License :: OSI Approved :: '
+ 'GNU General Public License v3 or later (GPLv3+)',
'Natural Language :: Bulgarian',
'Natural Language :: Catalan',
'Natural Language :: Chinese (Simplified)',
diff -r e20e5091c81f -r a22017465760 tests/__init__.py
--- a/tests/__init__.py Wed Dec 04 11:09:36 2019 +0100
+++ b/tests/__init__.py Sun Mar 01 12:33:53 2020 +0100
@@ -2,7 +2,7 @@
# this repository contains the full copyright notices and license terms.
try:
- from
trytond.modules.sale_product_customer.tests.test_sale_product_customer import
suite
+ from
trytond.modules.sale_product_customer.tests.test_sale_product_customer import
suite # noqa: E501
except ImportError:
from .test_sale_product_customer import suite
