changeset 21eb2ad34c68 in modules/sale_shipment_cost:default
details:
https://hg.tryton.org/modules/sale_shipment_cost?cmd=changeset;node=21eb2ad34c68
description:
Fix flake8 errors and warnings
We add the flake8 configuration used so we ensure everyone uses the
same.
We remove the usage of __all__ for non public API.
When possible, we rationalize the class name according to its __name__
and module.
issue9082
review297061002
diffstat:
.flake8 | 2 ++
__init__.py | 2 +-
sale.py | 6 ++----
setup.py | 8 +++++---
stock.py | 2 --
tests/__init__.py | 2 +-
6 files changed, 11 insertions(+), 11 deletions(-)
diffs (94 lines):
diff -r 42a9ecf86c01 -r 21eb2ad34c68 .flake8
--- /dev/null Thu Jan 01 00:00:00 1970 +0000
+++ b/.flake8 Sun Mar 01 12:33:53 2020 +0100
@@ -0,0 +1,2 @@
+[flake8]
+ignore=E123,E124,E126,E128,W503
diff -r 42a9ecf86c01 -r 21eb2ad34c68 __init__.py
--- a/__init__.py Mon Jan 13 23:49:48 2020 +0100
+++ b/__init__.py Sun Mar 01 12:33:53 2020 +0100
@@ -11,7 +11,7 @@
sale.Configuration,
sale.ConfigurationSaleMethod,
sale.Sale,
- sale.SaleLine,
+ sale.Line,
stock.ShipmentOut,
module='sale_shipment_cost', type_='model')
Pool.register(
diff -r 42a9ecf86c01 -r 21eb2ad34c68 sale.py
--- a/sale.py Mon Jan 13 23:49:48 2020 +0100
+++ b/sale.py Sun Mar 01 12:33:53 2020 +0100
@@ -12,8 +12,6 @@
from trytond.modules.product import price_digits
from trytond.modules.sale.exceptions import SaleConfirmError
-__all__ = ['Configuration', 'ConfigurationSaleMethod', 'Sale', 'SaleLine',
- 'ReturnSale', 'Promotion']
sale_shipment_cost_method = fields.Selection(
'get_sale_shipment_cost_methods', "Sale Shipment Cost Method")
@@ -303,12 +301,12 @@
return invoice
-class SaleLine(metaclass=PoolMeta):
+class Line(metaclass=PoolMeta):
__name__ = 'sale.line'
shipment_cost = fields.Numeric('Shipment Cost', digits=price_digits)
def _get_invoice_line_quantity(self):
- quantity = super(SaleLine, self)._get_invoice_line_quantity()
+ quantity = super()._get_invoice_line_quantity()
if self.shipment_cost:
if self.sale.shipment_cost_method == 'shipment':
return 0
diff -r 42a9ecf86c01 -r 21eb2ad34c68 setup.py
--- a/setup.py Mon Jan 13 23:49:48 2020 +0100
+++ b/setup.py Sun Mar 01 12:33:53 2020 +0100
@@ -81,8 +81,9 @@
keywords='tryton sale shipment cost',
package_dir={'trytond.modules.sale_shipment_cost': '.'},
packages=(
- ['trytond.modules.sale_shipment_cost'] +
- ['trytond.modules.sale_shipment_cost.%s' % p for p in find_packages()]
+ ['trytond.modules.sale_shipment_cost']
+ + ['trytond.modules.sale_shipment_cost.%s' % p
+ for p in find_packages()]
),
package_data={
'trytond.modules.sale_shipment_cost': (info.get('xml', [])
@@ -96,7 +97,8 @@
'Intended Audience :: Financial and Insurance Industry',
'Intended Audience :: Legal Industry',
'Intended Audience :: Manufacturing',
- 'License :: OSI Approved :: GNU General Public License v3 or later
(GPLv3+)',
+ 'License :: OSI Approved :: '
+ 'GNU General Public License v3 or later (GPLv3+)',
'Natural Language :: Bulgarian',
'Natural Language :: Catalan',
'Natural Language :: Chinese (Simplified)',
diff -r 42a9ecf86c01 -r 21eb2ad34c68 stock.py
--- a/stock.py Mon Jan 13 23:49:48 2020 +0100
+++ b/stock.py Sun Mar 01 12:33:53 2020 +0100
@@ -11,8 +11,6 @@
from trytond.modules.product import price_digits
from .exceptions import InvoiceShipmentCostError
-__all__ = ['ShipmentOut']
-
class ShipmentOut(metaclass=PoolMeta):
__name__ = 'stock.shipment.out'
diff -r 42a9ecf86c01 -r 21eb2ad34c68 tests/__init__.py
--- a/tests/__init__.py Mon Jan 13 23:49:48 2020 +0100
+++ b/tests/__init__.py Sun Mar 01 12:33:53 2020 +0100
@@ -2,7 +2,7 @@
# this repository contains the full copyright notices and license terms.
try:
- from trytond.modules.sale_shipment_cost.tests.test_sale_shipment_cost
import suite
+ from trytond.modules.sale_shipment_cost.tests.test_sale_shipment_cost
import suite # noqa: E501
except ImportError:
from .test_sale_shipment_cost import suite
