changeset d413b35c1624 in modules/sale_stock_quantity:default
details:
https://hg.tryton.org/modules/sale_stock_quantity?cmd=changeset;node=d413b35c1624
description:
Fix flake8 errors and warnings
We add the flake8 configuration used so we ensure everyone uses the
same.
We remove the usage of __all__ for non public API.
When possible, we rationalize the class name according to its __name__
and module.
issue9082
review297061002
diffstat:
.flake8 | 2 ++
__init__.py | 4 ++--
sale.py | 3 ---
setup.py | 8 +++++---
tests/__init__.py | 2 +-
5 files changed, 10 insertions(+), 9 deletions(-)
diffs (72 lines):
diff -r f9e26851e3c2 -r d413b35c1624 .flake8
--- /dev/null Thu Jan 01 00:00:00 1970 +0000
+++ b/.flake8 Sun Mar 01 12:33:53 2020 +0100
@@ -0,0 +1,2 @@
+[flake8]
+ignore=E123,E124,E126,E128,W503
diff -r f9e26851e3c2 -r d413b35c1624 __init__.py
--- a/__init__.py Tue Jan 21 00:33:11 2020 +0100
+++ b/__init__.py Sun Mar 01 12:33:53 2020 +0100
@@ -2,10 +2,10 @@
# this repository contains the full copyright notices and license terms.
from trytond.pool import Pool
-from .sale import *
+from . import sale
def register():
Pool.register(
- Sale,
+ sale.Sale,
module='sale_stock_quantity', type_='model')
diff -r f9e26851e3c2 -r d413b35c1624 sale.py
--- a/sale.py Tue Jan 21 00:33:11 2020 +0100
+++ b/sale.py Sun Mar 01 12:33:53 2020 +0100
@@ -12,9 +12,6 @@
from .exceptions import StockQuantityError, StockQuantityWarning
-__all__ = ['Sale']
-
-
class Sale(metaclass=PoolMeta):
__name__ = 'sale.sale'
diff -r f9e26851e3c2 -r d413b35c1624 setup.py
--- a/setup.py Tue Jan 21 00:33:11 2020 +0100
+++ b/setup.py Sun Mar 01 12:33:53 2020 +0100
@@ -82,8 +82,9 @@
keywords='tryton sale stock',
package_dir={'trytond.modules.sale_stock_quantity': '.'},
packages=(
- ['trytond.modules.sale_stock_quantity'] +
- ['trytond.modules.sale_stock_quantity.%s' % p for p in find_packages()]
+ ['trytond.modules.sale_stock_quantity']
+ + ['trytond.modules.sale_stock_quantity.%s' % p
+ for p in find_packages()]
),
package_data={
'trytond.modules.sale_stock_quantity': (info.get('xml', [])
@@ -98,7 +99,8 @@
'Intended Audience :: Financial and Insurance Industry',
'Intended Audience :: Legal Industry',
'Intended Audience :: Manufacturing',
- 'License :: OSI Approved :: GNU General Public License v3 or later
(GPLv3+)',
+ 'License :: OSI Approved :: '
+ 'GNU General Public License v3 or later (GPLv3+)',
'Natural Language :: Bulgarian',
'Natural Language :: Catalan',
'Natural Language :: Chinese (Simplified)',
diff -r f9e26851e3c2 -r d413b35c1624 tests/__init__.py
--- a/tests/__init__.py Tue Jan 21 00:33:11 2020 +0100
+++ b/tests/__init__.py Sun Mar 01 12:33:53 2020 +0100
@@ -2,7 +2,7 @@
# this repository contains the full copyright notices and license terms.
try:
- from trytond.modules.sale_stock_quantity.tests.test_sale_stock_quantity
import suite
+ from trytond.modules.sale_stock_quantity.tests.test_sale_stock_quantity
import suite # noqa: E501
except ImportError:
from .test_sale_stock_quantity import suite
