changeset e5f0c278394c in modules/stock_consignment:default
details:
https://hg.tryton.org/modules/stock_consignment?cmd=changeset;node=e5f0c278394c
description:
Fix flake8 errors and warnings
We add the flake8 configuration used so we ensure everyone uses the
same.
We remove the usage of __all__ for non public API.
When possible, we rationalize the class name according to its __name__
and module.
issue9082
review297061002
diffstat:
.flake8 | 2 ++
account.py | 2 --
setup.py | 7 ++++---
stock.py | 6 ++----
tests/__init__.py | 2 +-
5 files changed, 9 insertions(+), 10 deletions(-)
diffs (77 lines):
diff -r d4c40015f84f -r e5f0c278394c .flake8
--- /dev/null Thu Jan 01 00:00:00 1970 +0000
+++ b/.flake8 Sun Mar 01 12:33:54 2020 +0100
@@ -0,0 +1,2 @@
+[flake8]
+ignore=E123,E124,E126,E128,W503
diff -r d4c40015f84f -r e5f0c278394c account.py
--- a/account.py Wed Dec 04 11:09:36 2019 +0100
+++ b/account.py Sun Mar 01 12:33:54 2020 +0100
@@ -2,8 +2,6 @@
# this repository contains the full copyright notices and license terms.
from trytond.pool import PoolMeta, Pool
-__all__ = ['InvoiceLine']
-
class InvoiceLine(metaclass=PoolMeta):
__name__ = 'account.invoice.line'
diff -r d4c40015f84f -r e5f0c278394c setup.py
--- a/setup.py Wed Dec 04 11:09:36 2019 +0100
+++ b/setup.py Sun Mar 01 12:33:54 2020 +0100
@@ -80,8 +80,8 @@
keywords='tryton stock consignment',
package_dir={'trytond.modules.stock_consignment': '.'},
packages=(
- ['trytond.modules.stock_consignment'] +
- ['trytond.modules.stock_consignment.%s' % p for p in find_packages()]
+ ['trytond.modules.stock_consignment']
+ + ['trytond.modules.stock_consignment.%s' % p for p in find_packages()]
),
package_data={
'trytond.modules.stock_consignment': (info.get('xml', [])
@@ -96,7 +96,8 @@
'Intended Audience :: Financial and Insurance Industry',
'Intended Audience :: Legal Industry',
'Intended Audience :: Manufacturing',
- 'License :: OSI Approved :: GNU General Public License v3 or later
(GPLv3+)',
+ 'License :: OSI Approved :: '
+ 'GNU General Public License v3 or later (GPLv3+)',
'Natural Language :: Bulgarian',
'Natural Language :: Catalan',
'Natural Language :: Chinese (Simplified)',
diff -r d4c40015f84f -r e5f0c278394c stock.py
--- a/stock.py Wed Dec 04 11:09:36 2019 +0100
+++ b/stock.py Sun Mar 01 12:33:54 2020 +0100
@@ -8,9 +8,6 @@
from trytond.pool import PoolMeta, Pool
from trytond.pyson import Eval
-__all__ = ['Location', 'LocationLeadTime',
- 'Move', 'ShipmentInternal', 'Inventory', 'OrderPoint']
-
class Location(metaclass=PoolMeta):
__name__ = 'stock.location'
@@ -103,7 +100,8 @@
and not self.origin
and self.from_location
and self.to_location
- and ((self.from_location.type == 'supplier'
+ and ((
+ self.from_location.type == 'supplier'
and self.to_location.type in {
'storage', 'production', 'customer'})
or (self.from_location.type in {
diff -r d4c40015f84f -r e5f0c278394c tests/__init__.py
--- a/tests/__init__.py Wed Dec 04 11:09:36 2019 +0100
+++ b/tests/__init__.py Sun Mar 01 12:33:54 2020 +0100
@@ -2,7 +2,7 @@
# this repository contains the full copyright notices and license terms.
try:
- from trytond.modules.stock_consignment.tests.test_stock_consignment import
suite
+ from trytond.modules.stock_consignment.tests.test_stock_consignment import
suite # noqa: E501
except ImportError:
from .test_stock_consignment import suite
