changeset 1d3839d9c81b in modules/sale_subscription_asset:default
details:
https://hg.tryton.org/modules/sale_subscription_asset?cmd=changeset;node=1d3839d9c81b
description:
Fix flake8 errors and warnings
We add the flake8 configuration used so we ensure everyone uses the
same.
We remove the usage of __all__ for non public API.
When possible, we rationalize the class name according to its __name__
and module.
issue9082
review297061002
diffstat:
.flake8 | 2 ++
sale.py | 6 ++++--
setup.py | 7 ++++---
tests/__init__.py | 2 +-
4 files changed, 11 insertions(+), 6 deletions(-)
diffs (60 lines):
diff -r cd7c6cac2a0f -r 1d3839d9c81b .flake8
--- /dev/null Thu Jan 01 00:00:00 1970 +0000
+++ b/.flake8 Sun Mar 01 12:33:53 2020 +0100
@@ -0,0 +1,2 @@
+[flake8]
+ignore=E123,E124,E126,E128,W503
diff -r cd7c6cac2a0f -r 1d3839d9c81b sale.py
--- a/sale.py Wed Dec 04 11:09:36 2019 +0100
+++ b/sale.py Sun Mar 01 12:33:53 2020 +0100
@@ -137,10 +137,12 @@
| (other.start_date > line.start_date)
| (other.end_date > line.start_date)))
| ((line.end_date != Null)
- & (((other.end_date == Null)
+ & ((
+ (other.end_date == Null)
& (other.start_date < line.end_date))
| ((other.end_date != Null)
- & (((other.end_date >= line.start_date)
+ & ((
+ (other.end_date >= line.start_date)
& (other.end_date < line.end_date))
| ((other.start_date >= line.start_date)
& (other.start_date < line.end_date)))))))
diff -r cd7c6cac2a0f -r 1d3839d9c81b setup.py
--- a/setup.py Wed Dec 04 11:09:36 2019 +0100
+++ b/setup.py Sun Mar 01 12:33:53 2020 +0100
@@ -79,8 +79,8 @@
keywords='',
package_dir={'trytond.modules.sale_subscription_asset': '.'},
packages=(
- ['trytond.modules.sale_subscription_asset'] +
- ['trytond.modules.sale_subscription_asset.%s' % p
+ ['trytond.modules.sale_subscription_asset']
+ + ['trytond.modules.sale_subscription_asset.%s' % p
for p in find_packages()]
),
package_data={
@@ -95,7 +95,8 @@
'Intended Audience :: Developers',
'Intended Audience :: Financial and Insurance Industry',
'Intended Audience :: Legal Industry',
- 'License :: OSI Approved :: GNU General Public License v3 or later
(GPLv3+)',
+ 'License :: OSI Approved :: '
+ 'GNU General Public License v3 or later (GPLv3+)',
'Natural Language :: Bulgarian',
'Natural Language :: Catalan',
'Natural Language :: Chinese (Simplified)',
diff -r cd7c6cac2a0f -r 1d3839d9c81b tests/__init__.py
--- a/tests/__init__.py Wed Dec 04 11:09:36 2019 +0100
+++ b/tests/__init__.py Sun Mar 01 12:33:53 2020 +0100
@@ -2,7 +2,7 @@
# this repository contains the full copyright notices and license terms.
try:
- from
trytond.modules.sale_subscription_asset.tests.test_sale_subscription_asset
import suite
+ from
trytond.modules.sale_subscription_asset.tests.test_sale_subscription_asset
import suite # noqa: E501
except ImportError:
from .test_sale_subscription_asset import suite
