changeset c3ff33b7c3e9 in modules/sale_shipment_grouping:default
details:
https://hg.tryton.org/modules/sale_shipment_grouping?cmd=changeset;node=c3ff33b7c3e9
description:
Fix flake8 errors and warnings
We add the flake8 configuration used so we ensure everyone uses the
same.
We remove the usage of __all__ for non public API.
When possible, we rationalize the class name according to its __name__
and module.
issue9082
review297061002
diffstat:
.flake8 | 2 ++
__init__.py | 10 +++++-----
configuration.py | 3 ---
party.py | 2 --
sale.py | 2 --
setup.py | 8 +++++---
tests/__init__.py | 2 +-
7 files changed, 13 insertions(+), 16 deletions(-)
diffs (105 lines):
diff -r 693b04a63021 -r c3ff33b7c3e9 .flake8
--- /dev/null Thu Jan 01 00:00:00 1970 +0000
+++ b/.flake8 Sun Mar 01 12:33:53 2020 +0100
@@ -0,0 +1,2 @@
+[flake8]
+ignore=E123,E124,E126,E128,W503
diff -r 693b04a63021 -r c3ff33b7c3e9 __init__.py
--- a/__init__.py Fri Dec 06 17:33:47 2019 +0100
+++ b/__init__.py Sun Mar 01 12:33:53 2020 +0100
@@ -2,16 +2,16 @@
# this repository contains the full copyright notices and license terms.
from trytond.pool import Pool
-from .party import *
-from .sale import *
+from . import party
+from . import sale
from . import configuration
def register():
Pool.register(
- Party,
- PartySaleShipmentGroupingMethod,
- Sale,
+ party.Party,
+ party.PartySaleShipmentGroupingMethod,
+ sale.Sale,
configuration.Configuration,
configuration.ConfigurationSaleMethod,
module='sale_shipment_grouping', type_='model')
diff -r 693b04a63021 -r c3ff33b7c3e9 configuration.py
--- a/configuration.py Fri Dec 06 17:33:47 2019 +0100
+++ b/configuration.py Sun Mar 01 12:33:53 2020 +0100
@@ -3,9 +3,6 @@
from trytond.model import fields
from trytond.pool import Pool, PoolMeta
-__all__ = ['Configuration', 'ConfigurationSaleMethod']
-
-
sale_shipment_grouping_method = fields.Selection(
'get_sale_shipment_grouping_methods', "Sale Shipment Grouping Method",
help="The default shipment grouping method for new customers.")
diff -r 693b04a63021 -r c3ff33b7c3e9 party.py
--- a/party.py Fri Dec 06 17:33:47 2019 +0100
+++ b/party.py Sun Mar 01 12:33:53 2020 +0100
@@ -5,8 +5,6 @@
from trytond.pool import PoolMeta, Pool
from trytond.tools.multivalue import migrate_property
-__all__ = ['Party', 'PartySaleShipmentGroupingMethod']
-
class Party(metaclass=PoolMeta):
__name__ = 'party.party'
diff -r 693b04a63021 -r c3ff33b7c3e9 sale.py
--- a/sale.py Fri Dec 06 17:33:47 2019 +0100
+++ b/sale.py Sun Mar 01 12:33:53 2020 +0100
@@ -4,8 +4,6 @@
from trytond.pool import PoolMeta
from trytond.transaction import Transaction
-__all__ = ['Sale']
-
class Sale(metaclass=PoolMeta):
__name__ = 'sale.sale'
diff -r 693b04a63021 -r c3ff33b7c3e9 setup.py
--- a/setup.py Fri Dec 06 17:33:47 2019 +0100
+++ b/setup.py Sun Mar 01 12:33:53 2020 +0100
@@ -79,8 +79,9 @@
keywords='tryton sale shipment grouping',
package_dir={'trytond.modules.sale_shipment_grouping': '.'},
packages=(
- ['trytond.modules.sale_shipment_grouping'] +
- ['trytond.modules.sale_shipment_grouping.%s' % p for p in
find_packages()]
+ ['trytond.modules.sale_shipment_grouping']
+ + ['trytond.modules.sale_shipment_grouping.%s' % p
+ for p in find_packages()]
),
package_data={
'trytond.modules.sale_shipment_grouping': (info.get('xml', [])
@@ -93,7 +94,8 @@
'Intended Audience :: Developers',
'Intended Audience :: Financial and Insurance Industry',
'Intended Audience :: Legal Industry',
- 'License :: OSI Approved :: GNU General Public License v3 or later
(GPLv3+)',
+ 'License :: OSI Approved :: '
+ 'GNU General Public License v3 or later (GPLv3+)',
'Natural Language :: Bulgarian',
'Natural Language :: Catalan',
'Natural Language :: Chinese (Simplified)',
diff -r 693b04a63021 -r c3ff33b7c3e9 tests/__init__.py
--- a/tests/__init__.py Fri Dec 06 17:33:47 2019 +0100
+++ b/tests/__init__.py Sun Mar 01 12:33:53 2020 +0100
@@ -2,7 +2,7 @@
# this repository contains the full copyright notices and license terms.
try:
- from
trytond.modules.sale_shipment_grouping.tests.test_sale_shipment_grouping import
suite
+ from
trytond.modules.sale_shipment_grouping.tests.test_sale_shipment_grouping import
suite # noqa: E501
except ImportError:
from .test_sale_shipment_grouping import suite
