changeset c3423c8bfe66 in modules/stock_product_location:default
details:
https://hg.tryton.org/modules/stock_product_location?cmd=changeset;node=c3423c8bfe66
description:
Fix flake8 errors and warnings
We add the flake8 configuration used so we ensure everyone uses the
same.
We remove the usage of __all__ for non public API.
When possible, we rationalize the class name according to its __name__
and module.
issue9082
review297061002
diffstat:
.flake8 | 2 ++
location.py | 2 --
product.py | 2 --
production.py | 2 --
setup.py | 7 ++++---
tests/__init__.py | 2 +-
6 files changed, 7 insertions(+), 10 deletions(-)
diffs (78 lines):
diff -r 26fb2bfb4ed2 -r c3423c8bfe66 .flake8
--- /dev/null Thu Jan 01 00:00:00 1970 +0000
+++ b/.flake8 Sun Mar 01 12:33:54 2020 +0100
@@ -0,0 +1,2 @@
+[flake8]
+ignore=E123,E124,E126,E128,W503
diff -r 26fb2bfb4ed2 -r c3423c8bfe66 location.py
--- a/location.py Wed Dec 04 11:09:37 2019 +0100
+++ b/location.py Sun Mar 01 12:33:54 2020 +0100
@@ -5,8 +5,6 @@
from trytond.pyson import If, Eval, Bool
from trytond.pool import PoolMeta
-__all__ = ['ProductLocation', 'Move', 'ShipmentIn', 'ShipmentOutReturn']
-
class ProductLocation(sequence_ordered(), ModelSQL, ModelView, MatchMixin):
'''
diff -r 26fb2bfb4ed2 -r c3423c8bfe66 product.py
--- a/product.py Wed Dec 04 11:09:37 2019 +0100
+++ b/product.py Sun Mar 01 12:33:54 2020 +0100
@@ -4,8 +4,6 @@
from trytond.pyson import Eval
from trytond.pool import PoolMeta
-__all__ = ['Product']
-
class Product(metaclass=PoolMeta):
__name__ = 'product.product'
diff -r 26fb2bfb4ed2 -r c3423c8bfe66 production.py
--- a/production.py Wed Dec 04 11:09:37 2019 +0100
+++ b/production.py Sun Mar 01 12:33:54 2020 +0100
@@ -2,8 +2,6 @@
# this repository contains the full copyright notices and license terms.
from trytond.pool import Pool, PoolMeta
-__all__ = ['Production']
-
class Production(metaclass=PoolMeta):
__name__ = 'production'
diff -r 26fb2bfb4ed2 -r c3423c8bfe66 setup.py
--- a/setup.py Wed Dec 04 11:09:37 2019 +0100
+++ b/setup.py Sun Mar 01 12:33:54 2020 +0100
@@ -81,8 +81,8 @@
keywords='tryton stock product location',
package_dir={'trytond.modules.stock_product_location': '.'},
packages=(
- ['trytond.modules.stock_product_location'] +
- ['trytond.modules.stock_product_location.%s' % p
+ ['trytond.modules.stock_product_location']
+ + ['trytond.modules.stock_product_location.%s' % p
for p in find_packages()]
),
package_data={
@@ -97,7 +97,8 @@
'Intended Audience :: Developers',
'Intended Audience :: Legal Industry',
'Intended Audience :: Manufacturing',
- 'License :: OSI Approved :: GNU General Public License v3 or later
(GPLv3+)',
+ 'License :: OSI Approved :: '
+ 'GNU General Public License v3 or later (GPLv3+)',
'Natural Language :: Bulgarian',
'Natural Language :: Catalan',
'Natural Language :: Chinese (Simplified)',
diff -r 26fb2bfb4ed2 -r c3423c8bfe66 tests/__init__.py
--- a/tests/__init__.py Wed Dec 04 11:09:37 2019 +0100
+++ b/tests/__init__.py Sun Mar 01 12:33:54 2020 +0100
@@ -2,7 +2,7 @@
# this repository contains the full copyright notices and license terms.
try:
- from
trytond.modules.stock_product_location.tests.test_stock_product_location import
suite
+ from
trytond.modules.stock_product_location.tests.test_stock_product_location import
suite # noqa: E501
except ImportError:
from .test_stock_product_location import suite
