changeset 1eb7106a0713 in modules/stock_supply_day:default
details:
https://hg.tryton.org/modules/stock_supply_day?cmd=changeset;node=1eb7106a0713
description:
Fix flake8 errors and warnings
We add the flake8 configuration used so we ensure everyone uses the
same.
We remove the usage of __all__ for non public API.
When possible, we rationalize the class name according to its __name__
and module.
issue9082
review297061002
diffstat:
.flake8 | 2 ++
__init__.py | 6 +++---
purchase.py | 2 --
setup.py | 7 ++++---
tests/__init__.py | 2 +-
5 files changed, 10 insertions(+), 9 deletions(-)
diffs (72 lines):
diff -r e4659223ba83 -r 1eb7106a0713 .flake8
--- /dev/null Thu Jan 01 00:00:00 1970 +0000
+++ b/.flake8 Sun Mar 01 12:33:54 2020 +0100
@@ -0,0 +1,2 @@
+[flake8]
+ignore=E123,E124,E126,E128,W503
diff -r e4659223ba83 -r 1eb7106a0713 __init__.py
--- a/__init__.py Tue Jan 07 10:15:52 2020 +0100
+++ b/__init__.py Sun Mar 01 12:33:54 2020 +0100
@@ -2,11 +2,11 @@
# this repository contains the full copyright notices and license terms.
from trytond.pool import Pool
-from .purchase import *
+from . import purchase
def register():
Pool.register(
- ProductSupplier,
- ProductSupplierDay,
+ purchase.ProductSupplier,
+ purchase.ProductSupplierDay,
module='stock_supply_day', type_='model')
diff -r e4659223ba83 -r 1eb7106a0713 purchase.py
--- a/purchase.py Tue Jan 07 10:15:52 2020 +0100
+++ b/purchase.py Sun Mar 01 12:33:54 2020 +0100
@@ -5,8 +5,6 @@
from trytond.pool import PoolMeta, Pool
from trytond.transaction import Transaction
-__all__ = ['ProductSupplier', 'ProductSupplierDay']
-
class ProductSupplier(metaclass=PoolMeta):
__name__ = 'purchase.product_supplier'
diff -r e4659223ba83 -r 1eb7106a0713 setup.py
--- a/setup.py Tue Jan 07 10:15:52 2020 +0100
+++ b/setup.py Sun Mar 01 12:33:54 2020 +0100
@@ -78,8 +78,8 @@
keywords='tryton supply day',
package_dir={'trytond.modules.stock_supply_day': '.'},
packages=(
- ['trytond.modules.stock_supply_day'] +
- ['trytond.modules.stock_supply_day.%s' % p for p in find_packages()]
+ ['trytond.modules.stock_supply_day']
+ + ['trytond.modules.stock_supply_day.%s' % p for p in find_packages()]
),
package_data={
'trytond.modules.stock_supply_day': (info.get('xml', [])
@@ -92,7 +92,8 @@
'Intended Audience :: Developers',
'Intended Audience :: Legal Industry',
'Intended Audience :: Manufacturing',
- 'License :: OSI Approved :: GNU General Public License v3 or later
(GPLv3+)',
+ 'License :: OSI Approved :: '
+ 'GNU General Public License v3 or later (GPLv3+)',
'Natural Language :: Bulgarian',
'Natural Language :: Catalan',
'Natural Language :: Chinese (Simplified)',
diff -r e4659223ba83 -r 1eb7106a0713 tests/__init__.py
--- a/tests/__init__.py Tue Jan 07 10:15:52 2020 +0100
+++ b/tests/__init__.py Sun Mar 01 12:33:54 2020 +0100
@@ -2,7 +2,7 @@
# this repository contains the full copyright notices and license terms.
try:
- from trytond.modules.stock_supply_day.tests.test_stock_supply_day import
suite
+ from trytond.modules.stock_supply_day.tests.test_stock_supply_day import
suite # noqa: E501
except ImportError:
from .test_stock_supply_day import suite
