changeset 22abfffb95b5 in sao:5.4
details: https://hg.tryton.org/sao?cmd=changeset;node=22abfffb95b5
description:
Do not trigger trigger another on_change after setting it's result
issue9212
review311331002
(grafted from 0e779982f8bad44bc0da56b36f009b4bcfed5d27)
diffstat:
src/model.js | 13 +++++++++----
1 files changed, 9 insertions(+), 4 deletions(-)
diffs (47 lines):
diff -r 83ff01e2d1c2 -r 22abfffb95b5 src/model.js
--- a/src/model.js Sat Apr 18 17:20:57 2020 +0200
+++ b/src/model.js Sun Apr 19 13:11:48 2020 +0200
@@ -179,10 +179,13 @@
}
return record;
};
- array.remove = function(record, remove, modified, force_remove) {
+ array.remove = function(record, remove, modified, force_remove,
signal) {
if (modified === undefined) {
modified = true;
}
+ if (signal === undefined) {
+ signal = true;
+ }
var idx = this.indexOf(record);
if (record.id >= 0) {
if (remove) {
@@ -208,7 +211,9 @@
if ((record.id < 0) || force_remove) {
this._remove(record);
}
- record.group.changed();
+ if (signal) {
+ record.group.changed();
+ }
};
array._remove = function(record) {
var idx = this.indexOf(record);
@@ -2055,7 +2060,7 @@
for (var i = 0, len = group.length; i < len; i++) {
var old_record = group[i];
if (!~value.indexOf(old_record.id)) {
- group.remove(old_record, true);
+ group.remove(old_record, true, true, false, false);
}
}
group.load(value, modified);
@@ -2246,7 +2251,7 @@
}.bind(this));
}
to_remove.forEach(function(record2) {
- group.remove(record2, false, true, false);
+ group.remove(record2, false, true, false, false);
}.bind(this));
if (value.add || value.update) {