changeset 0b785a4d3328 in modules/sale_shipment_cost:default
details:
https://hg.tryton.org/modules/sale_shipment_cost?cmd=changeset;node=0b785a4d3328
description:
Always set a new shipment cost line on quotation
The optimization to skip creation based on existing line with the same
cost
does not ensure that other properties like taxes or product are valid.
issue9696
review292441002
diffstat:
sale.py | 6 +-----
1 files changed, 1 insertions(+), 5 deletions(-)
diffs (16 lines):
diff -r 4bffa3c7f8ba -r 0b785a4d3328 sale.py
--- a/sale.py Fri Oct 16 19:19:58 2020 +0200
+++ b/sale.py Mon Oct 19 00:13:08 2020 +0200
@@ -214,11 +214,7 @@
removed = []
lines = list(self.lines or [])
for line in self.lines:
- if line.type != 'line' or not line.shipment_cost:
- continue
- if cost_line and line.shipment_cost == cost:
- cost_line = None
- else:
+ if line.type == 'line' and line.shipment_cost:
lines.remove(line)
removed.append(line)
if cost_line:
