changeset e8ca28b28a5f in bugs.tryton.org:default
details: https://hg.tryton.org/bugs.tryton.org?cmd=changeset;node=e8ca28b28a5f
description:
        Add logging support for irker detector
diffstat:

 detectors/irker.py |  5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diffs (27 lines):

diff -r 4df453bb5551 -r e8ca28b28a5f detectors/irker.py
--- a/detectors/irker.py        Mon Oct 19 15:46:22 2020 +0200
+++ b/detectors/irker.py        Mon Oct 19 15:46:44 2020 +0200
@@ -4,11 +4,13 @@
 import re
 import json
 import socket
+import logging
 
 IRKER_HOST = 'localhost'
 IRKER_PORT = 6659
 
 max_content = 120
+logger = logging.getLogger(__name__)
 
 TEMPLATE = ('%(green)s%(author)s%(reset)s '
             '%(bluish)s#%(nodeid)s%(reset)s/%(title)s%(bold)s:%(bold)s '
@@ -83,8 +85,7 @@
     except Exception as e:
         # Ignore any errors in sending the irker;
         # if the server is down, that's just bad luck
-        # XXX might want to do some logging here
-        print('* Sending message to irker failed', str(e))
+        logger.error('* Sending message to irker failed', exc_info=True)
 
 def init(db):
     db.issue.react('create', notify_irker)

Reply via email to