changeset 13cf2df662a8 in modules/sale_shipment_cost:5.4
details:
https://hg.tryton.org/modules/sale_shipment_cost?cmd=changeset;node=13cf2df662a8
description:
Always set a new shipment cost line on quotation
The optimization to skip creation based on existing line with the same
cost
does not ensure that other properties like taxes or product are valid.
issue9696
review292441002
(grafted from 0b785a4d3328473187c2fab11d30f9dbf63c7e12)
diffstat:
sale.py | 6 +-----
1 files changed, 1 insertions(+), 5 deletions(-)
diffs (16 lines):
diff -r edb9753dff96 -r 13cf2df662a8 sale.py
--- a/sale.py Sat Apr 04 16:47:10 2020 +0200
+++ b/sale.py Mon Oct 19 00:13:08 2020 +0200
@@ -221,11 +221,7 @@
removed = []
lines = list(self.lines or [])
for line in self.lines:
- if line.type != 'line' or not line.shipment_cost:
- continue
- if cost_line and line.shipment_cost == cost:
- cost_line = None
- else:
+ if line.type == 'line' and line.shipment_cost:
lines.remove(line)
removed.append(line)
if cost_line:
