changeset ddbbb4aeed20 in modules/account_tax_rule_country:5.6
details: 
https://hg.tryton.org/modules/account_tax_rule_country?cmd=changeset&node=ddbbb4aeed20
description:
        Test origin has positive id before using it

        issue10186
        review359551002
        (grafted from 3c57ca86838ca7daed3784a45906f0637c24bfef)
diffstat:

 account.py |  8 ++++++--
 1 files changed, 6 insertions(+), 2 deletions(-)

diffs (25 lines):

diff -r 5db20edcf63a -r ddbbb4aeed20 account.py
--- a/account.py        Wed May 05 22:53:28 2021 +0200
+++ b/account.py        Fri Apr 23 20:33:03 2021 +0200
@@ -118,7 +118,9 @@
         pattern = super(InvoiceLine, self)._get_tax_rule_pattern()
 
         from_country = from_subdivision = to_country = to_subdivision = None
-        if SaleLine and isinstance(self.origin, SaleLine):
+        if (SaleLine
+                and isinstance(self.origin, SaleLine)
+                and self.origin.id >= 0):
             warehouse_address = self.origin.warehouse.address
             if warehouse_address:
                 from_country = warehouse_address.country
@@ -126,7 +128,9 @@
             shipment_address = self.origin.sale.shipment_address
             to_country = shipment_address.country
             to_subdivision = shipment_address.subdivision
-        elif PurchaseLine and isinstance(self.origin, PurchaseLine):
+        elif (PurchaseLine
+                and isinstance(self.origin, PurchaseLine)
+                and self.origin.id >= 0):
             invoice_address = self.origin.purchase.invoice_address
             from_country = invoice_address.country
             from_subdivision = invoice_address.subdivision

Reply via email to