changeset d8fb16963609 in modules/commission:5.8
details: 
https://hg.tryton.org/modules/commission?cmd=changeset&node=d8fb16963609
description:
        Do not reverse commission when canceling invoice with move

        issue10845
        review387121002
        (grafted from 8edc569fdc8713d2726b0d88970df1f6d6b45f75)
diffstat:

 invoice.py |  4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diffs (18 lines):

diff -r e2cda0a75ef8 -r d8fb16963609 invoice.py
--- a/invoice.py        Fri Apr 16 19:35:07 2021 +0200
+++ b/invoice.py        Thu Oct 21 00:06:08 2021 +0200
@@ -79,11 +79,13 @@
         pool = Pool()
         Commission = pool.get('commission')
 
+        invoices_to_revert_commission = [x for x in invoices if not x.move]
+
         super(Invoice, cls).cancel(invoices)
 
         to_delete = []
         to_save = []
-        for sub_invoices in grouped_slice(invoices):
+        for sub_invoices in grouped_slice(invoices_to_revert_commission):
             ids = [i.id for i in sub_invoices]
             to_delete += Commission.search([
                     ('invoice_line', '=', None),

Reply via email to