changeset bf263eccc31f in trytond:default
details: https://hg.tryton.org/trytond?cmd=changeset&node=bf263eccc31f
description:
        Patch user login method instead of assign Mock object

        Patch restores the original attribute on exit.
diffstat:

 trytond/tests/test_user.py |  38 ++++++++++++++++++++------------------
 1 files changed, 20 insertions(+), 18 deletions(-)

diffs (48 lines):

diff -r c3490ff03d1d -r bf263eccc31f trytond/tests/test_user.py
--- a/trytond/tests/test_user.py        Wed Nov 24 01:09:36 2021 +0100
+++ b/trytond/tests/test_user.py        Sat Nov 27 01:51:37 2021 +0100
@@ -225,24 +225,26 @@
         user = User(login='user')
         user.save()
 
-        User._login_always = Mock(return_value=user.id)
-        User._login_different = Mock(return_value=user.id + 1)
-        User._login_never = Mock(return_value=None)
-
-        for methods, result in (
-                ('never,never', None),
-                ('never,always', user.id),
-                ('always,never', user.id),
-                ('always,always', user.id),
-                ('never+never', None),
-                ('never+always', None),
-                ('always+never', None),
-                ('always+always', user.id),
-                ('always+different', None),
-                ):
-            with self.subTest(methods=methods, result=result):
-                with set_authentications(methods):
-                    self.assertEqual(User.get_login('user', {}), result)
+        with patch.object(User, '_login_always',
+                Mock(return_value=user.id), create=True), \
+                patch.object(User, '_login_different',
+                    Mock(return_value=user.id + 1), create=True), \
+                patch.object(User, '_login_never',
+                    Mock(return_value=None), create=True):
+            for methods, result in (
+                    ('never,never', None),
+                    ('never,always', user.id),
+                    ('always,never', user.id),
+                    ('always,always', user.id),
+                    ('never+never', None),
+                    ('never+always', None),
+                    ('always+never', None),
+                    ('always+always', user.id),
+                    ('always+different', None),
+                    ):
+                with self.subTest(methods=methods, result=result):
+                    with set_authentications(methods):
+                        self.assertEqual(User.get_login('user', {}), result)
 
     @with_transaction()
     def test_bad_authentication_logging(self):

Reply via email to