[tryton-commits] changeset in trytond:default Always return tuple for MultiSelection

[Cédric Krier]

changeset 897423a42a3f in trytond:default
details: https://hg.tryton.org/trytond?cmd=changeset&node=897423a42a3f
description:
        Always return tuple for MultiSelection

        issue11282
        review361021002
diffstat:

 CHANGELOG                                  |  1 +
 trytond/model/fields/multiselection.py     |  2 +-
 trytond/tests/test_field_multiselection.py |  8 ++++----
 3 files changed, 6 insertions(+), 5 deletions(-)

diffs (59 lines):

diff -r 347d108696ce -r 897423a42a3f CHANGELOG
--- a/CHANGELOG Sun Mar 20 01:40:28 2022 +0100
+++ b/CHANGELOG Sun Mar 20 01:45:22 2022 +0100
@@ -1,3 +1,4 @@
+* Always return tuple for MultiSelection
 * Use default selectors instead of select
 * Add batch option to push queue tasks
 * Support ref value for reference field
diff -r 347d108696ce -r 897423a42a3f trytond/model/fields/multiselection.py
--- a/trytond/model/fields/multiselection.py    Sun Mar 20 01:40:28 2022 +0100
+++ b/trytond/model/fields/multiselection.py    Sun Mar 20 01:45:22 2022 +0100
@@ -55,7 +55,7 @@
                 self.selection, RPC(instantiate=instantiate))
 
     def get(self, ids, model, name, values=None):
-        lists = {id: None for id in ids}
+        lists = {id: () for id in ids}
         for value in values or []:
             data = value[name]
             if data:
diff -r 347d108696ce -r 897423a42a3f trytond/tests/test_field_multiselection.py
--- a/trytond/tests/test_field_multiselection.py        Sun Mar 20 01:40:28 
2022 +0100
+++ b/trytond/tests/test_field_multiselection.py        Sun Mar 20 01:45:22 
2022 +0100
@@ -29,7 +29,7 @@
                     }])
 
         self.assertEqual(selection.selects, ('bar', 'foo'))
-        self.assertEqual(selection_none.selects, None)
+        self.assertEqual(selection_none.selects, ())
 
     @with_transaction()
     def test_create_not_in(self):
@@ -67,7 +67,7 @@
                     'dyn_selects': None,
                     }])
 
-        self.assertEqual(selection.dyn_selects, None)
+        self.assertEqual(selection.dyn_selects, ())
 
     @with_transaction()
     def test_create_dynamic_not_in(self):
@@ -100,7 +100,7 @@
                     'static_selects': None,
                     }])
 
-        self.assertEqual(selection.static_selects, None)
+        self.assertEqual(selection.static_selects, ())
 
     @with_transaction()
     def test_create_static_not_in(self):
@@ -183,7 +183,7 @@
                     'selects': None,
                     }])
 
-        self.assertEqual(selection.selects_string, None)
+        self.assertEqual(selection.selects_string, [])
 
     @with_transaction()
     def test_search_equals(self):