changeset 42f15d274878 in modules/account_payment:default
details:
https://hg.tryton.org/modules/account_payment?cmd=changeset&node=42f15d274878
description:
Send only the required fields when fetching a readonly view definition
issue11134
review380081002
diffstat:
account.py | 14 ++++----------
party.py | 4 ++--
payment.py | 32 ++++++++++++--------------------
3 files changed, 18 insertions(+), 32 deletions(-)
diffs (179 lines):
diff -r 7f5d93628f59 -r 42f15d274878 account.py
--- a/account.py Wed Apr 06 23:37:41 2022 +0200
+++ b/account.py Fri Apr 08 19:07:12 2022 +0200
@@ -31,8 +31,7 @@
currency='payment_currency', digits='payment_currency',
states={
'invisible': ~Eval('payment_kind'),
- },
- depends=['payment_kind']),
+ }),
'get_payment_amount', searcher='search_payment_amount')
payment_currency = fields.Function(fields.Many2One(
'currency.currency', "Payment Currency"),
@@ -41,8 +40,7 @@
readonly=True,
states={
'invisible': ~Eval('payment_kind'),
- },
- depends=['payment_kind'])
+ })
payment_kind = fields.Function(fields.Selection([
(None, ''),
] + KINDS, 'Payment Kind'), 'get_payment_kind')
@@ -53,7 +51,6 @@
(Eval('payment_kind') == 'payable')
& ((Eval('credit', 0) > 0) | (Eval('debit', 0) < 0))),
},
- depends=['payment_kind', 'debit', 'credit'],
help="Check if the line will be paid by direct debit.")
@classmethod
@@ -280,8 +277,7 @@
required=True, domain=[
('company', '=', Eval('company', -1)),
('currency', '=', Eval('currency', -1)),
- ],
- depends=['company', 'currency'])
+ ])
journals = fields.One2Many(
'account.payment.journal', None, 'Journals', readonly=True)
@@ -479,8 +475,7 @@
('company', 'in', [Eval('company', -1), None]),
('sequence_type', '=',
Id('account_payment', 'sequence_type_account_payment_group')),
- ],
- depends=['company'])
+ ])
@classmethod
def __register__(cls, module_name):
@@ -519,7 +514,6 @@
'invisible': Eval('type') != 'in',
'readonly': Eval('state') != 'draft',
},
- depends=['type', 'state'],
help="Check if the invoice is paid by direct debit.")
@classmethod
diff -r 7f5d93628f59 -r 42f15d274878 party.py
--- a/party.py Wed Apr 06 23:37:41 2022 +0200
+++ b/party.py Fri Apr 08 19:07:12 2022 +0200
@@ -45,7 +45,7 @@
context={
'company': Eval('company', -1),
},
- depends=['company'])
+ depends={'company'})
payment_direct_debit = payment_direct_debit
@@ -59,7 +59,7 @@
context={
'company': Eval('company', -1),
},
- depends=['company'])
+ depends={'company'})
journal = fields.Many2One(
'account.payment.journal', "Journal", required=True)
company = fields.Function(
diff -r 7f5d93628f59 -r 42f15d274878 payment.py
--- a/payment.py Wed Apr 06 23:37:41 2022 +0200
+++ b/payment.py Fri Apr 08 19:07:12 2022 +0200
@@ -69,16 +69,14 @@
journal = fields.Many2One('account.payment.journal', 'Journal',
required=True, readonly=True, domain=[
('company', '=', Eval('company', -1)),
- ],
- depends=['company'])
+ ])
kind = fields.Selection(KINDS, 'Kind', required=True, readonly=True)
payments = fields.One2Many(
'account.payment', 'group', 'Payments', readonly=True,
domain=[
('company', '=', Eval('company', -1)),
('journal', '=', Eval('journal', -1)),
- ],
- depends=['company', 'journal'])
+ ])
currency = fields.Function(fields.Many2One(
'currency.currency', "Currency"),
'on_change_with_currency', searcher='search_currency')
@@ -277,7 +275,6 @@
_STATES = {
'readonly': Eval('state') != 'draft',
}
-_DEPENDS = ['state']
class Payment(Workflow, ModelSQL, ModelView):
@@ -285,24 +282,23 @@
__name__ = 'account.payment'
company = fields.Many2One(
'company.company', "Company", required=True, select=True,
- states=_STATES, depends=_DEPENDS)
+ states=_STATES)
journal = fields.Many2One('account.payment.journal', 'Journal',
required=True, states=_STATES, domain=[
('company', '=', Eval('company', -1)),
- ],
- depends=_DEPENDS + ['company'])
+ ])
currency = fields.Function(fields.Many2One('currency.currency',
'Currency'), 'on_change_with_currency',
searcher='search_currency')
kind = fields.Selection(KINDS, 'Kind', required=True,
- states=_STATES, depends=_DEPENDS)
+ states=_STATES)
party = fields.Many2One(
'party.party', "Party", required=True, states=_STATES,
context={
'company': Eval('company', -1),
},
- depends=_DEPENDS + ['company'])
- date = fields.Date('Date', required=True, states=_STATES, depends=_DEPENDS)
+ depends={'company'})
+ date = fields.Date('Date', required=True, states=_STATES)
amount = Monetary(
"Amount", currency='currency', digits='currency', required=True,
states={
@@ -310,8 +306,7 @@
If(Eval('process_method') == 'manual',
['draft', 'processing'],
['draft'])),
- },
- depends=['state', 'process_method'])
+ })
line = fields.Many2One('account.move.line', 'Line', ondelete='RESTRICT',
domain=[
('move.company', '=', Eval('company', -1)),
@@ -338,15 +333,13 @@
],
('move_state', '=', 'posted'),
],
- states=_STATES, depends=_DEPENDS + ['party', 'currency', 'kind',
- 'company'])
- description = fields.Char('Description', states=_STATES, depends=_DEPENDS)
+ states=_STATES)
+ description = fields.Char('Description', states=_STATES)
origin = fields.Reference(
"Origin", selection='get_origin', select=True,
states={
'readonly': Eval('state') != 'draft',
- },
- depends=['state'])
+ })
group = fields.Many2One('account.payment.group', 'Group', readonly=True,
ondelete='RESTRICT',
states={
@@ -354,8 +347,7 @@
},
domain=[
('company', '=', Eval('company', -1)),
- ],
- depends=['state', 'company'])
+ ])
process_method = fields.Function(
fields.Selection('get_process_methods', "Process Method"),
'on_change_with_process_method', searcher='search_process_method')