changeset aac31f00ca6e in modules/sale_shipment_cost:default
details:
https://hg.tryton.org/modules/sale_shipment_cost?cmd=changeset&node=aac31f00ca6e
description:
Send only the required fields when fetching a readonly view definition
issue11134
review380081002
diffstat:
sale.py | 9 ++++-----
stock.py | 12 ++++--------
2 files changed, 8 insertions(+), 13 deletions(-)
diffs (82 lines):
diff -r 297e68b5e987 -r aac31f00ca6e sale.py
--- a/sale.py Wed Apr 06 23:37:44 2022 +0200
+++ b/sale.py Fri Apr 08 19:07:14 2022 +0200
@@ -87,7 +87,7 @@
context={
'company': Eval('company', -1),
},
- depends=['state', 'available_carriers', 'company'])
+ depends={'company'})
available_carriers = fields.Function(
fields.Many2Many('carrier', None, None, 'Available Carriers'),
'on_change_with_available_carriers')
@@ -97,7 +97,7 @@
('shipment', 'On Shipment'),
], 'Shipment Cost Method', states={
'readonly': Eval('state') != 'draft',
- }, depends=['state'])
+ })
@classmethod
def __register__(cls, module):
@@ -326,7 +326,7 @@
'sale_shipment_cost.msg_sale_shipment_cost_unique'),
]
# shipment_cost is needed to compute the unit_price
- cls.unit_price.depends.append('shipment_cost')
+ cls.unit_price.depends.add('shipment_cost')
@fields.depends('shipment_cost', 'unit_price')
def compute_unit_price(self):
@@ -404,8 +404,7 @@
"Amount with Shipment Cost Included",
states={
'invisible': ~Eval('amount'),
- },
- depends=['amount'])
+ })
@classmethod
def default_amount_shipment_cost_included(cls):
diff -r 297e68b5e987 -r aac31f00ca6e stock.py
--- a/stock.py Wed Apr 06 23:37:44 2022 +0200
+++ b/stock.py Fri Apr 08 19:07:14 2022 +0200
@@ -19,8 +19,7 @@
'invisible': (
Eval('cost_edit', False)
| (Eval('cost_method') != 'shipment')),
- },
- depends=['cost_edit', 'cost_method']),
+ }),
'on_change_with_cost_sale_currency_used')
cost_sale_currency = fields.Many2One(
'currency.currency', "Cost Sale Currency",
@@ -30,16 +29,14 @@
| (Eval('cost_method') != 'shipment')),
'required': Bool(Eval('cost_sale')),
'readonly': Eval('state').in_(['done', 'cancelled']),
- },
- depends=['cost_method', 'cost_sale', 'state'])
+ })
cost_sale_used = fields.Function(fields.Numeric(
"Cost Sale", digits=price_digits,
states={
'invisible': (
Eval('cost_edit', False)
| (Eval('cost_method') != 'shipment')),
- },
- depends=['cost_edit', 'cost_method']),
+ }),
'on_change_with_cost_sale_used')
cost_sale = fields.Numeric(
"Cost Sale", digits=price_digits,
@@ -48,8 +45,7 @@
~Eval('cost_edit', False)
| (Eval('cost_method') != 'shipment')),
'readonly': Eval('state').in_(['done', 'cancelled']),
- },
- depends=['cost_method', 'state'])
+ })
cost_invoice_line = fields.Many2One('account.invoice.line',
'Cost Invoice Line', readonly=True)
